Andrew/refactor tab api #394
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactors often touch a lot of parts, and this is a pretty big refactor. We reduce code deplication, improve errors and logic, and simply task management.
ayjayt
force-pushed
the
andrew/refactor-tab-api
branch
from
3b90fe6 to
31c210f
Compare
ayjayt
force-pushed
the
andrew/refactor-tab-api
branch
from
7d2f606 to
fb100a6
Compare
ayjayt
force-pushed
the
andrew/refactor-tab-api
branch
from
029aba5 to
33fb046
Compare
This commit is also in the fix-encoders test. The reason it wasn't used it because the mocker framework was being re-done in this commit. So its just sitting here in both unused. And at this point, modifying fix-encoder might provoke git to forget about conflicts already resolved. This reverts commit 94df9ac.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft status, halfway done, tests incoming