Skip to content

dcc: refactor dropdown #3440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Sep 22, 2025
Merged

dcc: refactor dropdown #3440

merged 13 commits into from
Sep 22, 2025

Conversation

KoolADE85
Copy link
Contributor

@KoolADE85 KoolADE85 commented Sep 15, 2025 •
edited
Loading

In this PR:

  • New Dropdown look-and-feel
  • Implemented as Typescript & a functional component
  • react-select is replaced with custom dropdown using Radix primitives as needed
  • typescript component generation bugfix to support writing props like (string | number | boolean)[]

Contributor Checklist

  • I have run the tests locally and they passed. (refer to testing section in contributing)
  • I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

optionals

  • I have added entry in the CHANGELOG.md
  • If this PR needs a follow-up in dash docs, community thread, I have mentioned the relevant URLS as follows
    • this GitHub #PR number updates the dash docs
    • here is the show and tell thread in Plotly Dash community

@gvwilson gvwilson added feature something new P1 needed for current cycle labels Sep 17, 2025
@KoolADE85 KoolADE85 marked this pull request as ready for review September 18, 2025 22:09
@KoolADE85 KoolADE85 force-pushed the feature/dcc-refactor-dropdown branch from 8cab0de to fa0e251 Compare September 18, 2025 22:31
T4rk1n
T4rk1n approved these changes Sep 19, 2025
View reviewed changes
Copy link
Contributor

@T4rk1n T4rk1n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💃

@KoolADE85 KoolADE85 merged commit 1113af6 into v4 Sep 22, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@T4rk1n T4rk1n T4rk1n approved these changes

@ndrezn ndrezn Awaiting requested review from ndrezn ndrezn is a code owner

@gvwilson gvwilson Awaiting requested review from gvwilson gvwilson is a code owner

@emilykl emilykl Awaiting requested review from emilykl emilykl is a code owner

Assignees

@KoolADE85 KoolADE85

Labels

feature something new P1 needed for current cycle

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@KoolADE85 @T4rk1n @gvwilson