Skip to content

dcc redesign: existing component bugfixes #3444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 22, 2025
Merged

dcc redesign: existing component bugfixes #3444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fd30f33
Be more judicious about setting a default step for non-integer sliders
KoolADE85 Sep 19, 2025
0afeaab
Visual tweaks for tooltips
KoolADE85 Sep 19, 2025
b7183a4
update tab order of slider inputs
KoolADE85 Sep 19, 2025
1f96d45
add missing vendor prefixes
KoolADE85 Sep 19, 2025
2348ae0
Move z-index ordering
KoolADE85 Sep 22, 2025
714b76e
Merge branch 'v4' into bugfix/slider-bugfixes
KoolADE85 Sep 22, 2025
af66266
commit for ci
KoolADE85 Sep 22, 2025
4ed1f65
Improve test reliability
KoolADE85 Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion components/dash-core-components/src/components/RangeSlider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,16 @@ export default function RangeSlider({
persistence_type = PersistenceTypes.local,
// eslint-disable-next-line no-magic-numbers
verticalHeight = 400,
step = 1,
step = undefined,
...props
}: RangeSliderProps) {
// Some considerations for the default value of `step`:
// If the range consists of integers, default to a value of `1`
// Otherwise, leave it undefined
if (Number.isInteger(props.min) && Number.isInteger(props.max)) {
step = 1;
}

return (
<Suspense fallback={null}>
<RealRangeSlider
Expand Down
8 changes: 8 additions & 0 deletions components/dash-core-components/src/components/css/sliders.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@
}

.dash-slider-thumb {
position: relative;
z-index: 1;
display: block;
width: 16px;
height: 16px;
Expand Down Expand Up @@ -185,10 +187,16 @@
min-width: 64px;
}

.dash-range-slider-max-input {
order: 1;
}

.dash-range-slider-input {
width: 64px;
margin-top: 8px;
-webkit-appearance: textfield;
-moz-appearance: textfield;
appearance: textfield;
}

/* Hide the number input spinners */
Expand Down
142 changes: 71 additions & 71 deletions components/dash-core-components/src/fragments/RangeSlider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,77 @@ export default function RangeSlider(props: RangeSliderProps) {
disabled={disabled}
/>
)}
{showInputs && !vertical && (
<input
type="number"
className="dash-input-container dash-range-slider-input dash-range-slider-max-input"
value={value[value.length - 1] ?? ''}
onChange={e => {
const inputValue = e.target.value;
// Allow empty string (user is clearing the field)
if (inputValue === '') {
// Don't update props while user is typing, just update local state
const newValue = [...value];
newValue[newValue.length - 1] = '' as any;
setValue(newValue);
} else {
const newMax = parseFloat(inputValue);
const constrainedMax = Math.max(
minMaxValues.min_mark,
Math.min(minMaxValues.max_mark, newMax)
);

if (newMax === constrainedMax) {
const newValue = [...value];
newValue[newValue.length - 1] = newMax;
setProps({
value: newValue,
drag_value: newValue,
});
}
}
}}
onBlur={e => {
const inputValue = e.target.value;
let newMax: number;

// If empty, default to current value or max_mark
if (inputValue === '') {
newMax =
value[value.length - 1] ??
minMaxValues.max_mark;
} else {
newMax = parseFloat(inputValue);
newMax = isNaN(newMax)
? minMaxValues.max_mark
: newMax;
}

const constrainedMax = Math.min(
minMaxValues.max_mark,
Math.max(
value[0] ?? minMaxValues.min_mark,
newMax
)
);
const newValue = [...value];
newValue[newValue.length - 1] = constrainedMax;
setValue(newValue);
if (updatemode === 'mouseup') {
setProps({value: newValue});
}
}}
pattern="^\\d*\\.?\\d*$"
min={
value.length === 1
? minMaxValues.min_mark
: value[0]
}
max={minMaxValues.max_mark}
step={step || undefined}
disabled={disabled}
/>
)}
<div
className="dash-slider-wrapper"
onClickCapture={e => e.preventDefault()} // prevent interactions from "clicking" the parent, particularly when slider is inside a label tag
Expand Down Expand Up @@ -334,77 +405,6 @@ export default function RangeSlider(props: RangeSliderProps) {
})}
</RadixSlider.Root>
</div>
{showInputs && !vertical && (
<input
type="number"
className="dash-input-container dash-range-slider-input"
value={value[value.length - 1] ?? ''}
onChange={e => {
const inputValue = e.target.value;
// Allow empty string (user is clearing the field)
if (inputValue === '') {
// Don't update props while user is typing, just update local state
const newValue = [...value];
newValue[newValue.length - 1] = '' as any;
setValue(newValue);
} else {
const newMax = parseFloat(inputValue);
const constrainedMax = Math.max(
minMaxValues.min_mark,
Math.min(minMaxValues.max_mark, newMax)
);

if (newMax === constrainedMax) {
const newValue = [...value];
newValue[newValue.length - 1] = newMax;
setProps({
value: newValue,
drag_value: newValue,
});
}
}
}}
onBlur={e => {
const inputValue = e.target.value;
let newMax: number;

// If empty, default to current value or max_mark
if (inputValue === '') {
newMax =
value[value.length - 1] ??
minMaxValues.max_mark;
} else {
newMax = parseFloat(inputValue);
newMax = isNaN(newMax)
? minMaxValues.max_mark
: newMax;
}

const constrainedMax = Math.min(
minMaxValues.max_mark,
Math.max(
value[0] ?? minMaxValues.min_mark,
newMax
)
);
const newValue = [...value];
newValue[newValue.length - 1] = constrainedMax;
setValue(newValue);
if (updatemode === 'mouseup') {
setProps({value: newValue});
}
}}
pattern="^\\d*\\.?\\d*$"
min={
value.length === 1
? minMaxValues.min_mark
: value[0]
}
max={minMaxValues.max_mark}
step={step || undefined}
disabled={disabled}
/>
)}
</div>
)}
</LoadingElement>
Expand Down
1 change: 1 addition & 0 deletions components/dash-core-components/tests/integration/misc/test_dcc_components_as_props.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ def test_mdcap001_dcc_components_as_props(dash_dcc):

search_input = dash_dcc.find_element("#dropdown .dash-dropdown-search")
search_input.send_keys("4")
sleep(0.25)
options = dash_dcc.find_elements("#dropdown .dash-dropdown-option")

wait.until(lambda: len(options) == 1, 1)
Expand Down