Skip to content

Implement #3722 Add date type to work with error bars #7570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Implement #3722 Add date type to work with error bars #7570

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions src/components/errorbars/calc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ module.exports = function calc(gd) {

function calcOneAxis(calcTrace, trace, axis, coord) {
var opts = trace['error_' + coord] || {};
var isVisible = (opts.visible && ['linear', 'log'].indexOf(axis.type) !== -1);
var isVisible = (opts.visible && ['linear', 'log', 'date'].indexOf(axis.type) !== -1);
var vals = [];

if(!isVisible) return;
Expand All @@ -53,14 +53,20 @@ function calcOneAxis(calcTrace, trace, axis, coord) {
else if(iIn === null) continue;

var calcCoord = calcPt[coord];
var coordVal = axis.c2l(calcCoord); // always numeric (ms for dates, raw for linear)

if(!isNumeric(coordVal)) continue;

var errors = computeError(coordVal, iIn);
if(isNumeric(errors[0]) && isNumeric(errors[1])) {
var shoe = coordVal - errors[0];
var hat = coordVal + errors[1];

if(!isNumeric(axis.c2l(calcCoord))) continue;
// convert back to axis coords
calcPt[coord + 's'] = axis.l2c(shoe);
calcPt[coord + 'h'] = axis.l2c(hat);

var errors = computeError(calcCoord, iIn);
if(isNumeric(errors[0]) && isNumeric(errors[1])) {
var shoe = calcPt[coord + 's'] = calcCoord - errors[0];
var hat = calcPt[coord + 'h'] = calcCoord + errors[1];
vals.push(shoe, hat);
vals.push(shoe, hat);
}
}

Expand Down