Skip to content

Fix dedicated stack provisioning #1455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2025
Merged

Fix dedicated stack provisioning #1455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/core/lib/core/services/cloud/configuration.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ defmodule Core.Services.Cloud.Configuration do
defp add_network(env, %ConsoleInstance{network: %ConsoleInstance.Network{allowed_cidrs: [_ | _] = cidrs}}) do
env ++ [network_allowd_cidrs: Jason.encode!(cidrs)]
end
defp add_network(_, _), do: []
defp add_network(env, _), do: env

defp add_oidc(env, %ConsoleInstance{oidc: %ConsoleInstance.OIDC{issuer: issuer, client_id: client_id, client_secret: client_secret}})
when is_binary(issuer) and is_binary(client_id) and is_binary(client_secret) do
Expand All @@ -95,7 +95,7 @@ defmodule Core.Services.Cloud.Configuration do
oidc_client_secret: client_secret
]
end
defp add_oidc(_, _), do: []
defp add_oidc(env, _), do: env

# defp certificate(%ConsoleInstance{postgres: %PostgresCluster{certificate: cert}}), do: cert

Expand Down
1 change: 1 addition & 0 deletions apps/core/test/services/cloud/workflow_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ defmodule Core.Services.Cloud.WorkflowTest do
assert attrs.repository_id == "repo-id"
assert attrs.git.ref == "main"
assert attrs.git.folder == "terraform/modules/dedicated/aws"
refute Enum.empty?(attrs.environment)

del_q = Console.queries(:stack_delete)
expect(Req, :post, fn _, [graphql: {^del_q, %{id: ^stack_id}}] ->
Expand Down
Loading