Skip to content

Add domain mapping feature with email validation #1460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 10, 2025
Merged

Add domain mapping feature with email validation #1460

merged 6 commits into from
Sep 10, 2025

Conversation

michaeljguarino
Copy link
Member

@michaeljguarino michaeljguarino commented Sep 9, 2025 •
edited by jsladerman
Loading

This was deprecated a while ago because of some obscure security related concerns, but this should solve for it:

  • require a user has a confirmed email with the same domain as the mapping
  • still ban common emails (gmail, hotmail, etc)

also closes PROD-3957

Test Plan

unit test

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.
  • I have added relevant labels to this PR to help with categorization for release notes.

@michaeljguarino michaeljguarino requested a review from a team September 9, 2025 15:55
@michaeljguarino michaeljguarino added the enhancement New feature or request label Sep 9, 2025
@michaeljguarino michaeljguarino force-pushed the domain-mapping-improvements branch from 2c8c6c8 to 4744e17 Compare September 9, 2025 16:22
@michaeljguarino
Add domain mapping feature with email validation
a5f29fb 
This was deprecated a while ago because of some obscure security related concerns, but this should solve for it:

* require a user has a confirmed email with the same domain as the mapping
* still ban common emails (gmail, hotmail, etc)
@michaeljguarino michaeljguarino force-pushed the domain-mapping-improvements branch from 4744e17 to a5f29fb Compare September 9, 2025 16:23
@jsladerman jsladerman requested a review from a team as a code owner September 9, 2025 22:47
@jsladerman jsladerman force-pushed the domain-mapping-improvements branch from 667493d to ccdf793 Compare September 9, 2025 23:19
@linear Linear
Copy link

linear bot commented Sep 10, 2025

PROD-3957 add domain mapping setup post-email confirmation

@michaeljguarino michaeljguarino merged commit 127311a into master Sep 10, 2025
16 checks passed
@michaeljguarino michaeljguarino deleted the domain-mapping-improvements branch September 10, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maciaszczykm maciaszczykm maciaszczykm approved these changes

@jsladerman jsladerman jsladerman approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@michaeljguarino @maciaszczykm @jsladerman