Refresh language registry when classpath changes #257
Merged
+63
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbynek
force-pushed
the
refresh-classpath
branch
from
ac0ef3b to
0ca434b
Compare
And remove the option to select single class files. This is not supported.
adangel
reviewed
Nov 27, 2025
Member
adangel
left a comment
adangel
left a comment
There was a problem hiding this comment.
Thanks for the PR!
Adding the field "currentClassloader" feels out of place.
I'll update the PR to use a different approach. We have here an event based system - if we look at the event, we know, what has changed...
Also I figured out, that selecting single class files doesn't work - and it never worked and will never work. That's not how classpaths work.
I'll add the possibility to select directories in addition to jar files.
adangel
added a commit
that referenced
this pull request
Nov 27, 2025
adangel
added a commit
that referenced
this pull request
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug referenced in
pmd/pmd#6113 (comment)