Skip to content

Log less #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
getkey merged 2 commits into from
Oct 9, 2025
Merged

Log less #287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f50e6af
Log less
getkey Oct 7, 2025
3c6fef7
PR review
getkey Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/signaling/handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ func Handler(ctx context.Context, store stores.Store, cloudflare *cloudflare.Cre
for {
select {
case <-ticker.C:
logger.Info("cleaning empty lobbies")
logger.Debug("cleaning empty lobbies")
if err := store.CleanEmptyLobbies(ctx, util.NowUTC(ctx).Add(-LobbyCleanThreshold)); err != nil {
logger.Error("failed to clean empty lobbies", zap.Error(err))
}
Expand Down Expand Up @@ -71,7 +71,7 @@ func Handler(ctx context.Context, store stores.Store, cloudflare *cloudflare.Cre
retrievedIDCallback: manager.Reconnected,
}
defer func() {
logger.Info("peer websocket closed", zap.String("peer", peer.ID), zap.String("game", peer.Game), zap.String("origin", r.Header.Get("Origin")))
logger.Debug("peer websocket closed", zap.String("peer", peer.ID), zap.String("game", peer.Game), zap.String("origin", r.Header.Get("Origin")))
conn.Close(websocket.StatusInternalError, "unexpected closure") // nolint:errcheck

if !peer.closedPacketReceived {
Expand Down
14 changes: 7 additions & 7 deletions internal/signaling/peer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ func (p *Peer) HandleHelloPacket(ctx context.Context, packet HelloPacket) error
hasReconnected := false
var reconnectingLobbies []string
if packet.ID != "" && packet.Secret != "" {
logger.Info("peer reconnecting", zap.String("game", packet.Game), zap.String("peer", packet.ID), zap.String("version", packet.Version))
logger.Debug("peer reconnecting", zap.String("game", packet.Game), zap.String("peer", packet.ID), zap.String("version", packet.Version))
var err error
hasReconnected, reconnectingLobbies, err = p.retrievedIDCallback(ctx, packet.ID, packet.Secret, packet.Game)
if err != nil {
Expand All @@ -219,7 +219,7 @@ func (p *Peer) HandleHelloPacket(ctx context.Context, packet HelloPacket) error
p.Game = packet.Game
p.ID = util.GeneratePeerID(ctx)
p.Secret = util.GenerateSecret(ctx)
logger.Info("peer connecting", zap.String("game", p.Game), zap.String("peer", p.ID), zap.String("version", packet.Version))
logger.Debug("peer connecting", zap.String("game", p.Game), zap.String("peer", p.ID), zap.String("version", packet.Version))

if err := p.store.CreatePeer(ctx, p.ID, p.Secret, p.Game); err != nil {
return fmt.Errorf("unable to create peer: %w", err)
Expand All @@ -237,7 +237,7 @@ func (p *Peer) HandleHelloPacket(ctx context.Context, packet HelloPacket) error

if hasReconnected {
for _, lobbyID := range reconnectingLobbies {
logger.Info("peer rejoining lobby", zap.String("game", p.Game), zap.String("peer", p.ID), zap.String("lobby", p.Lobby), zap.String("version", packet.Version))
logger.Debug("peer rejoining lobby", zap.String("game", p.Game), zap.String("peer", p.ID), zap.String("lobby", p.Lobby), zap.String("version", packet.Version))
p.Lobby = lobbyID
p.store.Subscribe(ctx, p.ForwardMessage, p.Game, p.Lobby, p.ID)

Expand Down Expand Up @@ -282,7 +282,7 @@ func (p *Peer) HandleClosePacket(ctx context.Context, packet ClosePacket) error

p.closedPacketReceived = true

logger.Info("client closed",
logger.Debug("client closed",
zap.String("game", p.Game),
zap.String("peer", p.ID),
zap.String("lobby", p.Lobby),
Expand Down Expand Up @@ -434,7 +434,7 @@ func (p *Peer) HandleCreatePacket(ctx context.Context, packet CreatePacket) erro
return err
}

logger.Info("created lobby", zap.String("game", p.Game), zap.String("lobby", p.Lobby), zap.String("peer", p.ID))
logger.Debug("created lobby", zap.String("game", p.Game), zap.String("lobby", p.Lobby), zap.String("peer", p.ID))
go metrics.Record(ctx, "lobby", "created", p.Game, p.ID, p.Lobby)

return p.Send(ctx, JoinedPacket{
Expand Down Expand Up @@ -512,7 +512,7 @@ func (p *Peer) HandleJoinPacket(ctx context.Context, packet JoinPacket) error {
}
}

logger.Info("joined lobby",
logger.Debug("joined lobby",
zap.String("game", p.Game),
zap.String("lobby", p.Lobby),
zap.String("peer", p.ID),
Expand Down Expand Up @@ -557,7 +557,7 @@ func (p *Peer) HandleUpdatePacket(ctx context.Context, packet LobbyUpdatePacket)
return err
}

logger.Info("lobby updated",
logger.Debug("lobby updated",
zap.String("game", p.Game),
zap.String("lobby", p.Lobby),
zap.String("peer", p.ID),
Expand Down
Loading