Add sign out in customer portal #6803
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Manas-Kenge is attempting to deploy a commit to the polar-sh Team on Vercel. A member of the Team first needs to authorize it. |
|
Can you share a working video of this in your local setup? |
Screencast.from.2025-09-14.10-43-09.webmHere is the video, we can probably add a confirmation dialog for sign out. |
frankie567
requested changes
Sep 15, 2025
There was a problem hiding this comment.
Thank you @Manas-Kenge, that's interesting!
The main issue for me here is that we just "forget" the token by removing it from the URL, but we actually don't revoke it in the backend. I already foresee the "security reports" we'll get because of this.
Can I ask you to add an endpoint in the backend so we can truly remove the session from the database?
|
Sounds good 👍 I’ll give it a shot when I get some time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6329
Add a sign out button in customer portal to log out customers