changes to make pxb compatible for Helm4 support#876
Open
vk-px wants to merge 2 commits intopre-release-2.11.0from
Open
changes to make pxb compatible for Helm4 support#876vk-px wants to merge 2 commits intopre-release-2.11.0from
vk-px wants to merge 2 commits intopre-release-2.11.0from
Conversation
px-kesavan
reviewed
Mar 24, 2026
vk-px
force-pushed
the
helm4-support-2.11.0-base
branch
from
68737af to
2b7a739
Compare
px-kesavan
reviewed
Apr 1, 2026
| apiVersion: v1 | ||
| kind: ServiceAccount | ||
| metadata: | ||
| name: px-backup-preflight-account |
Collaborator
There was a problem hiding this comment.
Suggested change
| name: px-backup-preflight-account | |
| name: pxcentral-preflight-account |
similarly ensure in other places
px-kesavan
reviewed
Apr 1, 2026
| {{- include "px-central.partOfLabel" . | nindent 4 }} | ||
| subjects: | ||
| - kind: ServiceAccount | ||
| name: px-backup-pre-install-account |
Collaborator
There was a problem hiding this comment.
Suggested change
| name: px-backup-pre-install-account | |
| name: pxcentral-pre-install-account |
px-kesavan
approved these changes
Apr 1, 2026
Collaborator
px-kesavan
left a comment
px-kesavan
left a comment
There was a problem hiding this comment.
Ensure we name the SA, Roles, cluster roles, RB and CRB with prefix pxcentral instead of px-backup to maintain uniformity with the corresponding job names
Lets merge it to private branch , instead of pre-release-2.11.0
vk-px
force-pushed
the
helm4-support-2.11.0-base
branch
from
2b7a739 to
4631632
Compare
vk-px
force-pushed
the
helm4-support-2.11.0-base
branch
from
4631632 to
d6603f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional)
Closes #
Special notes for your reviewer:
To be review with https://github.com/pure-px/pxcentral-onprem-operator/pull/324, the detailed aspects, scoping and arguments pertaining to the PR can be found in the document. https://docs.google.com/document/d/1sRFIi5KY17QgbVRqf_lLJ9BXap5BjYMTjyUgjoiFMUc/edit?tab=t.0,
where the error observed and the changes taken are detailed.