Skip to content

Conversation

@shikokuchuo
Copy link
Member

@shikokuchuo shikokuchuo commented May 8, 2025

Just a quick PR:

  1. Adds a 5s timeout so the client doesn't hang when querying. This could conceivably happen if code in a particular session is busy and not at the top level / calling later::run_now() for the promise to execute.

Tagging on some other minor changes:

  1. Some cosmetic tidy-ups - to refer to 'session' instead of 'i' during session selection, which I think is slightly nicer in the UI.
  2. Use the best platform-specific IPC transport (this needs to be onLoad so it's not saved when the package is built - it basically follows what mirai uses).
  3. Avoids suppressWarnings(), now I've made that possible.

Copy link
Collaborator

@simonpcouch simonpcouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕛🕐

@simonpcouch simonpcouch merged commit 7fceca6 into posit-dev:main May 9, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants