interface with the user's R session #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's really no functionality to be preserved here: * No longer need the node SDK + .ts interface to it * `mcp_config()` isn't needed because the config paths won't depend on the installation path of the package.
* `run_proxy()` becomes exported function `mcp_proxy()`, and the script becomes a package source file. This will error out on interactive use. * The server script becomes exported function `mcp_serve()`, which can only be used interactively. This function can be called in an `.Rprofile` to always start a server in new R sessions (but currently will error with more than one interactive R session). * envvar `ACQUAINT_PORT` controls the port where the server is hosted, and envvar `ACQUAINT_LOG_FILE` controls where the proxy writes its logs to.
wch
reviewed
Apr 14, 2025
| cli, | ||
| curl, | ||
| ellmer, | ||
| httpuv, |
There was a problem hiding this comment.
The httpuv dependency can also be dropped.
gadenbuie
reviewed
Apr 15, 2025
| return(NULL) | ||
| } | ||
|
|
||
| inputSchema <- compact(ellmer:::as_json(dummy_provider, tool@arguments)) |
There was a problem hiding this comment.
Does ellmer need an as_json(NULL, ToolDef) method or something that makes this easier? (It'd roll up the lines below, too)
There was a problem hiding this comment.
Could there be something like McpProvider? The format of the tool needs to look like this: https://modelcontextprotocol.io/docs/concepts/tools#tool-definition-structure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5.
New in this PR relative the
main: