Skip to content

Refactor Network Port Attach #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
michaelkad wants to merge 2 commits into from
Closed

Refactor Network Port Attach #124

michaelkad wants to merge 2 commits into from

Conversation

@michaelkad
Copy link
Collaborator

@michaelkad michaelkad commented May 22, 2024

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

=== RUN   TestAccIBMPINetworkPortAttachbasic
--- PASS: TestAccIBMPINetworkPortAttachbasic (1599.61s)
PASS

=== RUN   TestAccIBMPINetworkPortAttachVlanbasic
--- PASS: TestAccIBMPINetworkPortAttachVlanbasic (1422.39s)
PASS

@michaelkad michaelkad changed the title Refactor Network Port Refactor Network Port Attach May 22, 2024
@michaelkad michaelkad mentioned this pull request May 22, 2024
Closed
@michaelkad michaelkad force-pushed the network-port-attach branch from 14a23d3 to b8ac511 Compare May 22, 2024 16:02
@ismirlia ismirlia force-pushed the network-port-attach branch from 891eac3 to 740ffc6 Compare November 8, 2024 20:05
@ismirlia ismirlia force-pushed the network-port-attach branch from 740ffc6 to f688396 Compare November 8, 2024 20:10
Alexander-Kita
Alexander-Kita reviewed Nov 8, 2024
View reviewed changes
Alexander-Kita
Alexander-Kita reviewed Nov 8, 2024
View reviewed changes
Alexander-Kita
Alexander-Kita reviewed Nov 8, 2024
View reviewed changes
Alexander-Kita
Alexander-Kita reviewed Nov 8, 2024
View reviewed changes
Alexander-Kita
Alexander-Kita reviewed Nov 8, 2024
View reviewed changes
@ismirlia ismirlia force-pushed the network-port-attach branch from f688396 to 00f3504 Compare November 11, 2024 23:00
@ismirlia
Copy link
Collaborator

ismirlia commented Nov 20, 2024

Network port test:

--- PASS: TestAccIBMPINetworkPortAttachbasic (1261.30s)
PASS
--- PASS: TestAccIBMPINetworkPortAttachVlanbasic (1439.96s)
PASS

@ismirlia ismirlia force-pushed the network-port-attach branch from 7c864ee to 2e512fc Compare November 20, 2024 16:12
@ismirlia
Copy link
Collaborator

ismirlia commented Jan 14, 2025 •
edited
Loading

Output from acceptance testing:

--- PASS: TestAccIBMPINetworkPortAttachbasic (843.69s)
PASS
--- PASS: TestAccIBMPINetworkPortAttachVlanbasic (973.17s)
PASS

Data source tests:

--- PASS: TestAccIBMPIInstanceIPDataSource_basic (29.26s)
PASS

--- PASS: TestAccIBMPINetworkPortDataSource_basic (15.28s)
PASS

@ismirlia ismirlia force-pushed the network-port-attach branch from 38088ba to a141554 Compare January 14, 2025 18:09
Alexander-Kita
Alexander-Kita previously approved these changes Jan 14, 2025
View reviewed changes
@ismirlia ismirlia force-pushed the network-port-attach branch from a141554 to 1a1bfac Compare January 15, 2025 20:36
@ismirlia
Copy link
Collaborator

ismirlia commented Jan 16, 2025

Opened: IBM-Cloud#5920, closing this one.

@ismirlia ismirlia closed this Jan 16, 2025
@yussufsh yussufsh deleted the network-port-attach branch January 31, 2025 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ismirlia ismirlia ismirlia left review comments

@Alexander-Kita Alexander-Kita Alexander-Kita left review comments

Assignees

No one assigned

Labels

Refactor Resource

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@michaelkad @ismirlia @Alexander-Kita