Skip to content

[Datasource] VolumeSnapshot, VolumeSnaphots #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[Datasource] VolumeSnapshot, VolumeSnaphots #139

wants to merge 2 commits into from

Conversation

@michaelkad
Copy link
Collaborator

@michaelkad michaelkad commented Jul 15, 2024 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

=== RUN   TestAccIBMPIVolumeSnapshotsDataSourceBasic
--- PASS: TestAccIBMPIVolumeSnapshotsDataSourceBasic (12.08s)
PASS

=== RUN   TestAccIBMPIVolumeSnapshotDataSourceBasic
--- PASS: TestAccIBMPIVolumeSnapshotDataSourceBasic (11.10s)
PASS

@michaelkad michaelkad requested a review from ismirlia July 16, 2024 17:04
ismirlia
ismirlia reviewed Aug 14, 2024
View reviewed changes
@ismirlia
Copy link
Collaborator

I think after salmaan's change https://github.ibm.com/power-iaas/service-broker/pull/4262, this will be relabeled as volume-snapshots, so that needs to be updated.

@michaelkad michaelkad changed the title [Datasource] Snapshot, Snaphots [Datasource] VolumeSnapshot, VolumeSnaphots Aug 20, 2024
@michaelkad michaelkad requested a review from ismirlia September 4, 2024 13:44
@ismirlia
Copy link
Collaborator

Opened: IBM-Cloud#5674, closing this one

@ismirlia ismirlia closed this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ismirlia ismirlia Awaiting requested review from ismirlia

Assignees

No one assigned

Labels

Datasource Q3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@michaelkad @ismirlia