Skip to content

Conversation

@Alexander-Kita
Copy link
Collaborator

@Alexander-Kita Alexander-Kita commented Aug 5, 2024

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

pi_volume_group (d):

=== RUN   TestAccIBMPIVolumeGroupDataSource_basic
--- PASS: TestAccIBMPIVolumeGroupDataSource_basic (10.44s)
PASS

pi_volume_groups (d):

=== RUN   TestAccIBMPIVolumeGroupsDataSource_basic
--- PASS: TestAccIBMPIVolumeGroupsDataSource_basic (13.01s)
PASS

pi_volume_group_details (d):

=== RUN   TestAccIBMPIVolumeGroupDetailsDataSource_basic
--- PASS: TestAccIBMPIVolumeGroupDetailsDataSource_basic (8.56s)
PASS

pi_volume_groups_details (d):

=== RUN   TestAccIBMPIVolumeGroupsDetailsDataSource_basic
--- PASS: TestAccIBMPIVolumeGroupsDetailsDataSource_basic (15.04s)
PASS

pi_volume_group (r):

=== RUN   TestAccIBMPIVolumeGroupUpdate
--- PASS: TestAccIBMPIVolumeGroupUpdate (355.05s)
PASS

Description:

  • Adds attributes storage_pool, replication_sites, and auxiliary as attributes to pi_volume_group, pi_volume_groups, pi_volume_group_details, and pi_volume_groups_details data sources.

  • Adds replication_sites to pi_volume_group resource

  • Adds status_description_errors attribute into schema (missing previously)

@Alexander-Kita Alexander-Kita self-assigned this Aug 5, 2024
Copy link
Collaborator

@michaelkad michaelkad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments

@Alexander-Kita Alexander-Kita force-pushed the add-gsr-attributes-volume-groups-d branch from 5614687 to 30f1dbc Compare August 7, 2024 15:19
@Alexander-Kita Alexander-Kita changed the title Add gsr attributes to pi volume group data sources and related Add GRS attributes to pi volume group data sources and related Aug 7, 2024
Copy link
Collaborator

@michaelkad michaelkad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more comments.

Copy link
Collaborator

@michaelkad michaelkad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update for resource_ibm_pi_volume_group are missing

@Alexander-Kita Alexander-Kita force-pushed the add-gsr-attributes-volume-groups-d branch from c728530 to f44e129 Compare August 27, 2024 15:18
@Alexander-Kita
Copy link
Collaborator Author

@michaelkad Re-requesting review for replication sites attribute checking

Copy link
Collaborator

@michaelkad michaelkad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Alexander-Kita Alexander-Kita force-pushed the add-gsr-attributes-volume-groups-d branch from 87b66be to 98d040c Compare September 5, 2024 15:20
@michaelkad michaelkad added the Q3 label Sep 13, 2024
@Alexander-Kita Alexander-Kita force-pushed the add-gsr-attributes-volume-groups-d branch from d7d4de5 to d527de7 Compare September 19, 2024 17:05
@Alexander-Kita Alexander-Kita force-pushed the add-gsr-attributes-volume-groups-d branch from 2d243a2 to 5c2a165 Compare September 23, 2024 16:10
@Alexander-Kita
Copy link
Collaborator Author

Opened in main repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants