-
Notifications
You must be signed in to change notification settings - Fork 2
Add GRS attributes to pi volume group data sources and related #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
michaelkad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments
5614687 to
30f1dbc
Compare
michaelkad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few more comments.
michaelkad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update for resource_ibm_pi_volume_group are missing
c728530 to
f44e129
Compare
|
@michaelkad Re-requesting review for replication sites attribute checking |
michaelkad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
87b66be to
98d040c
Compare
d7d4de5 to
d527de7
Compare
Co-authored-by: michaelkad <[email protected]>
Co-authored-by: michaelkad <[email protected]>
2d243a2 to
5c2a165
Compare
|
Opened in main repo. |
Community Note
Relates OR Closes #0000
Output from acceptance testing:
pi_volume_group (d):
pi_volume_groups (d):
pi_volume_group_details (d):
pi_volume_groups_details (d):
pi_volume_group (r):
Description:
Adds attributes storage_pool, replication_sites, and auxiliary as attributes to pi_volume_group, pi_volume_groups, pi_volume_group_details, and pi_volume_groups_details data sources.
Adds replication_sites to pi_volume_group resource
Adds status_description_errors attribute into schema (missing previously)