Skip to content

Conversation

@Alexander-Kita
Copy link
Collaborator

@Alexander-Kita Alexander-Kita commented Sep 23, 2024

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

=== RUN   TestAccIBMPISPPPlacementGroupBasic
--- PASS: TestAccIBMPISPPPlacementGroupBasic (1148.60s)
PASS

Copy link
Collaborator

@ismirlia ismirlia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you sort this block as well

d.Set(Arg_CloudInstanceID, cloudInstanceID)
	d.Set(Arg_SPPPlacementGroupName, response.Name)
	d.Set(Attr_SPPPlacementGroupID, response.ID)
	d.Set(Arg_SPPPlacementGroupPolicy, response.Policy)
d.Set(Attr_SPPPlacementGroupMembers, response.MemberSharedProcessorPools)

@Alexander-Kita Alexander-Kita changed the title Refactor resource spp placement group and documentation Refactor resource spp placement group and documentation [WIP] Feb 3, 2025
@Alexander-Kita Alexander-Kita changed the title Refactor resource spp placement group and documentation [WIP] Refactor resource spp placement group and documentation [Tests WIP] Feb 3, 2025
@Alexander-Kita Alexander-Kita changed the title Refactor resource spp placement group and documentation [Tests WIP] Refactor resource spp placement group and documentation Feb 3, 2025
@Alexander-Kita
Copy link
Collaborator Author

Opened: IBM-Cloud#5962

@yussufsh yussufsh deleted the spp-refactor branch February 12, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants