Adding VSN Resources, datasources, and attributes #173

Alexander-Kita · 2024-10-17T20:43:31Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

pi_virtual_serial_number (d):

=== RUN   TestAccIBMPIVirtualSerialNumber
--- PASS: TestAccIBMPIVirtualSerialNumber (29.53s)
PASS

pi_virtual_serial_numbers (d):

=== RUN   TestAccIBMPIVirtualSerialNumbers
--- PASS: TestAccIBMPIVirtualSerialNumbers (27.74s)
PASS

pi_virtual_serial_number (r)

=== RUN   TestAccIBMPIVirtualSerialNumberBasic
--- PASS: TestAccIBMPIVirtualSerialNumberBasic (44.18s)
PASS

=== RUN   TestAccIBMPIVirtualSerialNumberWithInstance
--- PASS: TestAccIBMPIVirtualSerialNumberWithInstance (310.44s)
PASS

pi_instance (d)

=== RUN   TestAccIBMPIInstanceDataSource_basic
--- PASS: TestAccIBMPIInstanceDataSource_basic (44.95s)
PASS

pi_instances (d)

=== RUN   TestAccIBMPIInstancesDataSource_basic
--- PASS: TestAccIBMPIInstancesDataSource_basic (22.78s)
PASS

pi_instance (r)

=== RUN   TestAccIBMPIInstanceBasic
--- PASS: TestAccIBMPIInstanceBasic (998.46s)
PASS

=== RUN   TestAccIBMPIInstanceVirtualSerialNumber
--- PASS: TestAccIBMPIInstanceVirtualSerialNumber (413.08s)
PASS

michaelkad

Few comments

ibm/service/power/data_source_ibm_pi_virtual_serial_number.go

ibm/service/power/data_source_ibm_pi_virtual_serial_numbers.go

ibm/service/power/resource_ibm_pi_instance.go

ibm/service/power/data_source_ibm_pi_virtual_serial_number.go

michaelkad

We are missing data_source_pi_instance.go and data_source_pi_instances.go

Alexander-Kita · 2024-10-23T02:08:22Z

@michaelkad Added to datasources

michaelkad

Doc review

website/docs/d/pi_instance.html.markdown

website/docs/d/pi_instances.html.markdown

website/docs/d/pi_virtual_serial_number.html.markdown

website/docs/d/pi_virtual_serial_numbers.html.markdown

website/docs/r/pi_virtual_serial_number.html.markdown

ibm/service/power/data_source_ibm_pi_virtual_serial_number_test.go

ibm/service/power/resource_ibm_pi_virtual_serial_number_test.go

ibm/service/power/resource_ibm_pi_virtual_serial_number.go

website/docs/d/pi_virtual_serial_numbers.html.markdown

website/docs/r/pi_virtual_serial_number.html.markdown

ibm/service/power/resource_ibm_pi_virtual_serial_number_test.go

michaelkad

Few comments

website/docs/d/pi_virtual_serial_numbers.html.markdown

website/docs/r/pi_virtual_serial_number.html.markdown

website/docs/r/pi_instance.html.markdown

website/docs/r/pi_virtual_serial_number.html.markdown

website/docs/d/pi_virtual_serial_numbers.html.markdown

website/docs/d/pi_virtual_serial_number.html.markdown

Alexander-Kita · 2024-11-20T20:25:15Z

@ismirlia Docs fixed in latest push

ibm/service/power/data_source_ibm_pi_virtual_serial_number.go

ibm/service/power/resource_ibm_pi_virtual_serial_number.go

ismirlia · 2024-12-05T15:07:22Z

website/docs/r/pi_virtual_serial_number.html.markdown

+  - `region` - `lon`
+  - `zone` - `lon04`
+
+  Example usage:


Suggested change

Example usage:

Example usage:

website/docs/r/pi_virtual_serial_number.html.markdown

…d resources

michaelkad

lgtm

ismirlia

lgtm

Alexander-Kita · 2024-12-05T19:18:32Z

Opened in main repo: IBM-Cloud#5854

Alexander-Kita requested review from ismirlia and michaelkad October 17, 2024 20:43

michaelkad reviewed Oct 21, 2024

View reviewed changes

Alexander-Kita force-pushed the vsn-instances branch from 45f5804 to a86f59d Compare October 22, 2024 01:09

Alexander-Kita requested a review from michaelkad October 22, 2024 01:16

michaelkad reviewed Oct 22, 2024

View reviewed changes

ibm/service/power/data_source_ibm_pi_virtual_serial_number.go Outdated Show resolved Hide resolved

Alexander-Kita requested a review from michaelkad October 22, 2024 21:12

michaelkad requested changes Oct 22, 2024

View reviewed changes

Alexander-Kita requested a review from michaelkad October 23, 2024 13:01

michaelkad requested changes Oct 28, 2024

View reviewed changes

Alexander-Kita requested a review from michaelkad October 28, 2024 19:36

ismirlia reviewed Oct 29, 2024

View reviewed changes

website/docs/d/pi_virtual_serial_numbers.html.markdown Outdated Show resolved Hide resolved

ismirlia reviewed Oct 29, 2024

View reviewed changes

website/docs/r/pi_virtual_serial_number.html.markdown Outdated Show resolved Hide resolved

ismirlia reviewed Oct 29, 2024

View reviewed changes

website/docs/r/pi_virtual_serial_number.html.markdown Outdated Show resolved Hide resolved

ismirlia reviewed Oct 29, 2024

View reviewed changes

website/docs/r/pi_virtual_serial_number.html.markdown Outdated Show resolved Hide resolved

Alexander-Kita force-pushed the vsn-instances branch from 0af58cb to 16d8c67 Compare October 30, 2024 05:16

Alexander-Kita requested a review from ismirlia October 30, 2024 14:05

Alexander-Kita force-pushed the vsn-instances branch from 0230adf to 8923d77 Compare October 30, 2024 15:40

michaelkad requested changes Nov 1, 2024

View reviewed changes

ibm/service/power/resource_ibm_pi_virtual_serial_number_test.go Outdated Show resolved Hide resolved

Alexander-Kita requested a review from michaelkad November 1, 2024 14:07

Alexander-Kita force-pushed the vsn-instances branch from ec1792d to 9118750 Compare November 4, 2024 16:21

michaelkad requested changes Nov 5, 2024

View reviewed changes

website/docs/d/pi_virtual_serial_numbers.html.markdown Outdated Show resolved Hide resolved

website/docs/r/pi_virtual_serial_number.html.markdown Outdated Show resolved Hide resolved

website/docs/r/pi_virtual_serial_number.html.markdown Show resolved Hide resolved

Alexander-Kita force-pushed the vsn-instances branch 3 times, most recently from a438936 to b1de83b Compare November 5, 2024 19:35

michaelkad previously approved these changes Nov 5, 2024

View reviewed changes

Alexander-Kita marked this pull request as ready for review November 5, 2024 20:42

Alexander-Kita dismissed michaelkad’s stale review via 93618d2 November 5, 2024 20:42

Alexander-Kita force-pushed the vsn-instances branch from 89122c4 to 38d0f61 Compare November 20, 2024 17:05

ismirlia reviewed Nov 20, 2024

View reviewed changes

website/docs/r/pi_virtual_serial_number.html.markdown Outdated Show resolved Hide resolved

ismirlia reviewed Nov 20, 2024

View reviewed changes

website/docs/r/pi_instance.html.markdown Outdated Show resolved Hide resolved

ismirlia reviewed Nov 20, 2024

View reviewed changes

website/docs/r/pi_virtual_serial_number.html.markdown Show resolved Hide resolved

ismirlia reviewed Nov 20, 2024

View reviewed changes

website/docs/d/pi_virtual_serial_numbers.html.markdown Show resolved Hide resolved

ismirlia reviewed Nov 20, 2024

View reviewed changes

website/docs/d/pi_virtual_serial_number.html.markdown Show resolved Hide resolved

Alexander-Kita added the Q4 label Nov 20, 2024

Alexander-Kita force-pushed the vsn-instances branch from 38d0f61 to 3bdad81 Compare November 20, 2024 20:25

Alexander-Kita requested review from ismirlia and michaelkad November 20, 2024 20:25

ismirlia reviewed Nov 22, 2024

View reviewed changes

ibm/service/power/data_source_ibm_pi_virtual_serial_number.go Outdated Show resolved Hide resolved

Alexander-Kita force-pushed the vsn-instances branch from 3bdad81 to f12ea95 Compare November 22, 2024 20:33

ismirlia previously approved these changes Nov 22, 2024

View reviewed changes

Alexander-Kita dismissed ismirlia’s stale review via 8769da5 December 4, 2024 20:50

Alexander-Kita force-pushed the vsn-instances branch 5 times, most recently from eea561d to ff58df5 Compare December 5, 2024 00:06

ismirlia reviewed Dec 5, 2024

View reviewed changes

ibm/service/power/resource_ibm_pi_virtual_serial_number.go Show resolved Hide resolved

ismirlia reviewed Dec 5, 2024

View reviewed changes

website/docs/r/pi_virtual_serial_number.html.markdown Outdated Show resolved Hide resolved

[Resource] [Datasource] Power add VSN functionality to datasources an…

de3cf43

…d resources

Alexander-Kita force-pushed the vsn-instances branch from ff58df5 to de3cf43 Compare December 5, 2024 16:08

Alexander-Kita requested a review from ismirlia December 5, 2024 16:09

michaelkad approved these changes Dec 5, 2024

View reviewed changes

ismirlia approved these changes Dec 5, 2024

View reviewed changes

Alexander-Kita closed this Dec 5, 2024

Adding VSN Resources, datasources, and attributes #173

Adding VSN Resources, datasources, and attributes #173

Uh oh!

Conversation

Alexander-Kita commented Oct 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Community Note

Uh oh!

michaelkad left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

michaelkad left a comment

Choose a reason for hiding this comment

Uh oh!

Alexander-Kita commented Oct 23, 2024

Uh oh!

michaelkad left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

michaelkad left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Alexander-Kita commented Nov 20, 2024

Uh oh!

Uh oh!

Uh oh!

ismirlia Dec 5, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

michaelkad left a comment

Choose a reason for hiding this comment

Uh oh!

ismirlia left a comment

Choose a reason for hiding this comment

Uh oh!

Alexander-Kita commented Dec 5, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Alexander-Kita commented Oct 17, 2024 •

edited

Loading