forked from IBM-Cloud/terraform-provider-ibm
-
Notifications
You must be signed in to change notification settings - Fork 2
[R] Added the Volume TargetCRN option and a corresponding unitest #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
r-patange
wants to merge
12
commits into
master
Choose a base branch
from
volume-targetCRN
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 3ac6abf)
(cherry picked from commit 4f75755)
(cherry picked from commit 92a6f6b)
(cherry picked from commit fa7bbee)
Pull in upstream changes from to keep aligned. Included cherry-picks: - 3ac6abf Add toolchain err - 4f75755 Sort constants - 92a6f6b [R] Volume Group - fa7bbee add ReplicationTargetCRN - 396c9a1 Update go.sum Conflicts resolved in: - ibm/service/power/ibm_pi_constants.go Ran to reconcile module sums. No behavioral changes beyond ReplicationTargetCRN support and constants reordering; builds clean locally.
ismirlia
reviewed
Nov 4, 2025
…to ReplicationTargetCRN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates OR Closes #0000
--- PASS: TestAccIBMPIVolumebasic (88.44s)
PASS
--- PASS: TestAccIBMPIVolumeDeleteWithTargetCRN (51.43s)
PASS
--- PASS: TestAccIBMPIVolumePool (51.61s)
PASS
--- PASS: TestAccIBMPIVolumeGRS (212.27s)
PASS
--- PASS: TestAccIBMPIVolumeUpdate (60.94s)
PASS
--- PASS: TestAccIBMPIVolumeUserTags (84.03s)
PASS