Skip to content

Conversation

@michaelkad
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'
--- PASS: TestAccIBMPINetworkPortDataSource_basic (37.01s)
PASS
--- PASS: TestAccIBMPINetworkDataSource_basic (57.51s)
PASS

User will get this error if they provide both arguments.
Error: Conflicting configuration arguments
	with data.ibm_pi_network.testacc_ds_network, 
	on terraform_plugin_test.tf line 5, in data "ibm_pi_network"   "testacc_ds_network": 5: pi_network_id = "0095fe96-d919-4d68-be3a-1844db3de4ce"

	"pi_network_id": conflicts with pi_network_name
Error: Conflicting configuration arguments
	with data.ibm_pi_network.testacc_ds_network, on terraform_plugin_test.tf line 6, in data "ibm_pi_network" "testacc_ds_network": 6: pi_network_name = "net_sample3-3340"
	"pi_network_name": conflicts with pi_network_id
...

@michaelkad michaelkad added the enhancement New feature or request label Sep 24, 2025
@michaelkad michaelkad marked this pull request as ready for review September 24, 2025 18:33
ismirlia
ismirlia previously approved these changes Sep 24, 2025
Copy link
Collaborator

@ismirlia ismirlia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ismirlia
Copy link
Collaborator

ismirlia commented Sep 24, 2025

Oh one more thing, you may have to reinstate this field. We probably still need an attribute to display the name of the network somewhere.

            Attr_Name: {
				Computed:    true,
				Deprecated:  "This field is deprecated, use pi_network_name instead.",
				Description: "The unique identifier or name of a network.",
				Type:        schema.TypeString,
			},

ismirlia
ismirlia previously approved these changes Sep 30, 2025
ismirlia
ismirlia previously approved these changes Oct 10, 2025
Copy link
Collaborator

@ismirlia ismirlia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Add network name
Update doc
sync master
@michaelkad michaelkad closed this Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Datasource enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants