Skip to content

Fix instance data sources to use id #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Fix instance data sources to use id #266

wants to merge 3 commits into from

Conversation

@ismirlia
Copy link
Collaborator

@ismirlia ismirlia commented Oct 6, 2025 •
edited
Loading

Deprecate the use of pi_instance_name on the ibm_pi_instance, ibm_pi_instance_console_languages, ibm_pi_instance_volumes, ibm_pi_instance_ip, and ibm_pi_pvm_snapshot data sources for pi_instance_id.

Output from acceptance testing:

--- PASS: TestAccIBMPIInstanceDataSource_basic (44.64s)
PASS

--- PASS: TestAccIBMPIInstanceConsoleLanguages (18.56s)
PASS

--- PASS: TestAccIBMPIInstanceVolumesDataSource_basic (23.19s)
PASS

--- PASS: TestAccIBMPISnapshotDataSource_basic (18.25s)
PASS

--- PASS: TestAccIBMPIInstanceIPDataSource_basic (22.42s)
PASS

@ismirlia ismirlia added enhancement New feature or request Datasource labels Oct 6, 2025
michaelkad
michaelkad requested changes Oct 6, 2025
View reviewed changes
Copy link
Collaborator

@michaelkad michaelkad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing [data_source_ibm_pi_instance_ip.go]

michaelkad
michaelkad reviewed Oct 6, 2025
View reviewed changes
@ismirlia ismirlia requested a review from michaelkad October 6, 2025 19:23
@ismirlia
Copy link
Collaborator Author

Opened: IBM-Cloud#6506, closing this one.

@ismirlia ismirlia closed this Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@r-patange r-patange r-patange approved these changes

@michaelkad michaelkad Awaiting requested review from michaelkad

Assignees

No one assigned

Labels

Datasource enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ismirlia @michaelkad @r-patange