Remove spurious setup requirements, and setup.py #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since setuptools 46.4.0 (May 2020), `attr:` are statically extracted using the `ast` module if possible: pypa/setuptools#1753
We can now get rid of setup.py! 🎉
Collaborator
Author
|
The CI failure on Windows/Py3.9 is spurious (Cirrus' VM didn't cleanly come up apparently) |
Collaborator
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 15, 2022
221: Remove spurious setup requirements, and setup.py r=pathunstrom a=nbraud - Drop spurious setup requirements `setuptools` can now deal with `attr:` without needing to import the package. - Move dependency options to `setup.cfg` There was nothing non-trivial left in `setup.py`, so I removed it too ;3 Co-authored-by: nicoo <[email protected]>
Contributor
|
Build failed: |
Collaborator
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Nov 15, 2022
221: Remove spurious setup requirements, and setup.py r=pathunstrom a=nbraud - Drop spurious setup requirements `setuptools` can now deal with `attr:` without needing to import the package. - Move dependency options to `setup.cfg` There was nothing non-trivial left in `setup.py`, so I removed it too ;3 Co-authored-by: nicoo <[email protected]>
Contributor
|
Build failed: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setuptoolscan now deal withattr:without needing to import the package.setup.cfgThere was nothing non-trivial left in
setup.py, so I removed it too ;3