Add missing GAMEventHandler callbacks for click and impression events#1252
Open
berkbtasdemir wants to merge 1 commit intoprebid:masterfrom
Open
Add missing GAMEventHandler callbacks for click and impression events#1252berkbtasdemir wants to merge 1 commit intoprebid:masterfrom
berkbtasdemir wants to merge 1 commit intoprebid:masterfrom
Conversation
berkbtasdemir
force-pushed
the
add-GAMHandler-callback
branch
2 times, most recently
from
21ecbac to
b6933fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements missing GADBannerViewDelegate callback methods.
Changes
1. Implement Missing GADBannerViewDelegate Methods
Added
bannerViewDidRecordImpression(_:)implementationGAMBannerEventHandler.swiftBannerViewDelegate.bannerViewDidDisplay(_:)didDisplayAd()method toBannerEventInteractionDelegateprotocol to support this flowdidDisplayAd()inBannerViewto notify the delegateAdded
bannerViewDidRecordClick(_:)implementationGAMBannerEventHandler.swiftBannerViewDelegate.bannerViewWillLeaveApplication(_:)willLeaveApp()method inBannerEventInteractionDelegate