Skip to content

Conversation

ferrerodbgm
Copy link
Contributor

🏷 Type of documentation

  • new bid adapter
  • update bid adapter
  • new feature
  • text edit only (wording, typos)
  • bugfix (code examples)
  • new examples

📋 Checklist

@netlify
Copy link

netlify bot commented Sep 29, 2025

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit e485e11
🔍 Latest deploy log https://app.netlify.com/projects/prebid-docs-preview/deploys/68f0e4b47c899f00082c833b
😎 Deploy Preview https://deploy-preview-6271--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@monis0395 monis0395 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be great, if you can be explicit yes or no with all values where its check with bidder

image

@ferrerodbgm
Copy link
Contributor Author

Hi @monis0395,

We filled all necessary fields.

Could you review please?

Thanks.

@ferrerodbgm ferrerodbgm requested a review from monis0395 October 16, 2025 09:11
Copy link
Contributor

@monis0395 monis0395 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, but there are some errors:

  1. the preview is not opening properly see https://deploy-preview-6271--prebid-docs-preview.netlify.app/dev-docs/empower.html (see image below)
  2. also the url will change once to fix the folder location https://deploy-preview-6271--prebid-docs-preview.netlify.app/dev-docs/bidders/empower.html
  3. the filter search is also not working because of errors
image

@ferrerodbgm ferrerodbgm requested a review from monis0395 October 16, 2025 12:11
@ferrerodbgm
Copy link
Contributor Author

Hi @monis0395,

Sorry for the path. I changed the document according to your feedbacks.

Thanks

Copy link
Contributor

@monis0395 monis0395 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChrisHuie ChrisHuie merged commit 99a0191 into prebid:master Oct 20, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants