-
Notifications
You must be signed in to change notification settings - Fork 0
feat: update AWS provider in aws-eks module #940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
felixglezprefapp
wants to merge
9
commits into
main
Choose a base branch
from
feature/bump-aws-provider-version-aws-eks
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
15d731d
Bump aws provider version and update documentation
felixglezprefapp a1a425c
Bumb provider version in example code
felixglezprefapp c46e33a
Bump EKS module version
felixglezprefapp 2e261c8
Update module version variables
felixglezprefapp 6f1088b
Upgrade fargate_profiles definition
felixglezprefapp 2a9367d
Update karpenter and revert change to fargate_profiles variable
felixglezprefapp 7c45d6b
Change node group with subnets to keep the current interface
felixglezprefapp 871e715
Add default module options
felixglezprefapp 149a9af
Remove duplicates and add debug output
felixglezprefapp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,30 +1,18 @@ | ||
| module "karpenter" { | ||
| count = var.enable_karpenter == true ? 1 : 0 | ||
|
|
||
|
|
||
| source = "terraform-aws-modules/eks/aws//modules/karpenter" | ||
| version = "20.33.1" | ||
| version = "21.0.0" | ||
| cluster_name = var.cluster_name | ||
|
|
||
| iam_role_name = format("%s-karpenter-role", var.cluster_name) # Used to generate the instance profile | ||
| create_iam_role = true | ||
| enable_v1_permissions = true | ||
| enable_irsa = true | ||
|
|
||
| iam_role_use_name_prefix = false | ||
| iam_policy_use_name_prefix = true | ||
| node_iam_role_use_name_prefix = false | ||
| irsa_oidc_provider_arn = module.eks.oidc_provider_arn | ||
| irsa_namespace_service_accounts = ["karpenter:karpenter-sa"] | ||
|
|
||
| # Since the node group role will already have an access entry | ||
| create_access_entry = true | ||
| iam_role_name = format("%s-karpenter-role", var.cluster_name) # Used to generate the instance profile | ||
| create_iam_role = true | ||
| iam_role_use_name_prefix = false | ||
| iam_policy_use_name_prefix = true | ||
| create_access_entry = true | ||
| node_iam_role_additional_policies = { | ||
| AmazonSSMManagedInstanceCore = "arn:aws:iam::aws:policy/AmazonSSMManagedInstanceCore" | ||
| Ec2ExtraPolicy = aws_iam_policy.iam_policy_extra_karpenter[0].arn | ||
| } | ||
|
|
||
| queue_name = format("karpenter-%s", var.cluster_name) | ||
| tags = var.tags | ||
|
|
||
| } | ||
| tags = var.tags | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.