Py rattler build refactor #1966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfv
force-pushed
the
py-rattler-build-refactor
branch
from
4486951 to
47f3017
Compare
Hofer-Julian
reviewed
Nov 3, 2025
Comment on lines
+12
to
+19
| # For type checking, use Any as placeholder since we don't have stubs | ||
| _Stage1Recipe = Any | ||
| _Stage1Package = Any | ||
| _Stage1Build = Any | ||
| _Stage1Requirements = Any | ||
| _Stage1About = Any | ||
| _Stage1Source = Any | ||
| _Stage1StagingCache = Any |
There was a problem hiding this comment.
Why would this be necessary?
Hofer-Julian
reviewed
Nov 3, 2025
| self._inner = inner | ||
|
|
||
| @property | ||
| def homepage(self) -> Optional[str]: |
There was a problem hiding this comment.
Let's remember to use ruff here to migrate all use cases of Optional[str] to the newer str | None syntax
| } | ||
|
|
||
| /// Get the compression level | ||
| #[getter] |
There was a problem hiding this comment.
I am curious about the heavy use of implicit getters and setters in this API.
My impression is that it's more common to use PyPackagingSettings.set_compression_level(..) instead of PyPackagingSettings.compression_level = .., especially if there's logic happening behind the scenes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.