Skip to content

feat(DataTable): Add prop to allow range selection over multiple pages #7782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(DataTable): Add prop to allow range selection over multiple pages #7782

wants to merge 1 commit into from

Conversation

rayman-de
Copy link
Contributor

@rayman-de rayman-de commented Mar 13, 2025 •
edited
Loading

### Defect Fixes
Fix #7778: When accessing processedData, props.first is now correctly substracted from rowIndex to get the right index in the array.

Feature Requests

Additionally, anchorRowIndex was needlessly resetted on each page change, prohibiting selection over multiple pages. This is now possible through the new prop multiPageRangeSelection

@github-actions GitHub Actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@rayman-de rayman-de force-pushed the rayman-de-7778-fix-datatable-lazy-range-selection branch from 611e6cc to befca51 Compare March 13, 2025 10:01
@github-actions GitHub Actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@vercel Vercel
Copy link

vercel bot commented Mar 13, 2025

Deployment failed with the following error:

Creating the Deployment Timed Out.

@github-actions GitHub Actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@melloware
Copy link
Member

@rayman-de this is great but we should check PrimeVue and whether it behaves correctly or incorreclty. I don't like adding new props that don't match PrimeVue unless absolutely necessary.

@melloware melloware added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Mar 13, 2025
@melloware
Copy link
Member

I created a stackblitz is LOOKS like PrimeVue has the same bug? https://stackblitz.com/edit/x8rejugz?file=src%2FApp.vue

@rayman-de rayman-de force-pushed the rayman-de-7778-fix-datatable-lazy-range-selection branch from 0173203 to cb868ea Compare March 13, 2025 12:27
@rayman-de
Copy link
Contributor Author

I created a stackblitz is LOOKS like PrimeVue has the same bug? https://stackblitz.com/edit/x8rejugz?file=src%2FApp.vue

Well I have not done any programming with Vue yet, so I cannot do much with that Stackblitz.

What is the desired behaviour? Of course, we could allow range selections over multiple pages by default, I just was not sure whether that is wanted

@melloware
Copy link
Member

yeah your PR makes sense to me.

@melloware melloware requested a review from mertsincan March 13, 2025 12:36
@melloware
Copy link
Member

I assigned to PrimeTek to review.

@rayman-de
Copy link
Contributor Author

Thanks!

@rayman-de
Copy link
Contributor Author

What does the failed Vercel check mean? Is there a mistake in the PR?

@melloware
Copy link
Member

Oh its failing the PrimeReact v9 deployment but that has been broken for a while you don't need to worry about it.

@rayman-de rayman-de force-pushed the rayman-de-7778-fix-datatable-lazy-range-selection branch from cb868ea to bf7ab04 Compare March 13, 2025 16:41
@rayman-de
Copy link
Contributor Author

Should I maybe splitt off the feature-request part here so that you can just merge the bugfixing part without having to wait for @mertsincan ?

@melloware
Copy link
Member

Yes open another PR with just the bugfix part please.

@rayman-de rayman-de force-pushed the rayman-de-7778-fix-datatable-lazy-range-selection branch from bf7ab04 to 2012d49 Compare March 19, 2025 12:19
@vercel Vercel
Copy link

vercel bot commented Mar 19, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Mar 19, 2025 0:35am
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview Mar 19, 2025 0:35am

@rayman-de rayman-de changed the title Fix #7778: Fix index calculation for datatables with lazy loading feat(DataTable): Add prop to allow range selection over multiple pages Mar 19, 2025
@rayman-de
Copy link
Contributor Author

Hmm, I cannot change the branch name for this PR (which is now just the multiPageRangeSelection prop

@rayman-de
Copy link
Contributor Author

Yes open another PR with just the bugfix part please.

Here: #7799

@melloware melloware force-pushed the rayman-de-7778-fix-datatable-lazy-range-selection branch from 2012d49 to 1c65e79 Compare March 19, 2025 12:34
@melloware
Copy link
Member

OK i just rebased this branch!

@melloware melloware force-pushed the rayman-de-7778-fix-datatable-lazy-range-selection branch from 1c65e79 to 3d0b37c Compare May 22, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mertsincan mertsincan Awaiting requested review from mertsincan

Assignees

@mertsincan mertsincan

Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DataTable: Shift-Selection does not work on page 2+ with lazy loading enabled
3 participants
@rayman-de @melloware @mertsincan