fix(blockui): Improve mask handling and prevent memory leaks #8173
+49
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add pendingTimer to manage timeout and prevent multiple timers - Enhance removeMask method with additional safety checks - Prevent memory leaks by clearing timers and removing event listeners - Add null checks before removing mask from DOM - Reset mask to null after removal to prevent stale references - Improve unblock and beforeUnmount lifecycle methods for better cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defect Fixes
When toggling the blocked property of BlockUI rapidly (e.g. multiple times in quick succession), the UI can end up in a broken state: visually it appears “unblocked” (i.e. the dark overlay is gone), but the interface is still non‑interactive (i.e. you can’t click or interact with buttons).
Here is more info about issues -7817