Skip to content

fix(DatePicker): prevent error when selecting time with showTime #8200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+10 −7
Open

fix(DatePicker): prevent error when selecting time with showTime #8200

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d6bd8c
fix(DatePicker): prevent error when selecting time with showTime
navedqb Oct 15, 2025
eb43aca
Merge pull request #65 from navedqb/fix--8197
navedqb Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions packages/primevue/src/datepicker/DatePicker.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1649,12 +1649,13 @@ export default {
validateTime(hour, minute, second, pm) {
let value = this.viewDate;
const convertedHour = this.convertTo24Hour(hour, pm);
const hasRawValues = Array.isArray(this.rawValue) && this.rawValue.length;

if (this.isRangeSelection()) {
if (this.isRangeSelection() && hasRawValues) {
value = this.rawValue[1] || this.rawValue[0];
}

if (this.isMultipleSelection()) {
if (this.isMultipleSelection() && hasRawValues) {
value = this.rawValue[this.rawValue.length - 1];
}

Expand Down Expand Up @@ -1784,12 +1785,13 @@ export default {
updateModelTime() {
this.timePickerChange = true;
let value = this.viewDate;
const hasRawValues = Array.isArray(this.rawValue) && this.rawValue.length;

if (this.isRangeSelection()) {
if (this.isRangeSelection() && hasRawValues) {
value = this.rawValue[this.focusedDateIndex] || this.rawValue[0];
}

if (this.isMultipleSelection()) {
if (this.isMultipleSelection() && hasRawValues) {
value = this.rawValue[this.rawValue.length - 1];
}

Expand All @@ -1806,17 +1808,18 @@ export default {
value.setSeconds(this.currentSecond);

if (this.isRangeSelection()) {
if (this.focusedDateIndex === 1 && this.rawValue[1]) {
if (this.focusedDateIndex === 1 && this.rawValue && this.rawValue[1]) {
value = [this.rawValue[0], value];
} else if (this.focusedDateIndex === 0) {
value = [value, this.rawValue[1]];
value = [value, (this.rawValue && this.rawValue[1]) || null];
} else {
value = [value, null];
}
}

if (this.isMultipleSelection()) {
value = [...this.rawValue.slice(0, -1), value];
const existingValues = Array.isArray(this.rawValue) ? this.rawValue.slice(0, -1) : [];
value = [...existingValues, value];
}

this.updateModel(value);
Expand Down
Loading