-
-
Notifications
You must be signed in to change notification settings - Fork 220
feat: add events #413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
MrCrayon
wants to merge
2
commits into
prism-php:main
Choose a base branch
from
MrCrayon:feat/prism-events
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat: add events #413
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Prism\Prism\Events; | ||
|
|
||
| class HttpRequestCompleted extends TraceEvent | ||
| { | ||
| /** | ||
| * @param array<string, mixed> $attributes | ||
| * @param string[][] $headers | ||
| */ | ||
| public function __construct( | ||
| public readonly int $statusCode, | ||
| public readonly array $headers, | ||
| public readonly array $attributes, | ||
| public readonly ?\Throwable $exception = null | ||
| ) { | ||
| parent::__construct(); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Prism\Prism\Events; | ||
|
|
||
| class HttpRequestStarted extends TraceEvent | ||
| { | ||
| /** | ||
| * @param array<string, mixed> $attributes | ||
| * @param string[][] $headers | ||
| */ | ||
| public function __construct( | ||
| public readonly string $method, | ||
| public readonly string $url, | ||
| public readonly array $headers, | ||
| public readonly array $attributes, | ||
| ) { | ||
| parent::__construct(); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Prism\Prism\Events; | ||
|
|
||
| class PrismRequestCompleted extends TraceEvent | ||
| { | ||
| /** | ||
| * @param array<string, mixed> $attributes | ||
| */ | ||
| public function __construct( | ||
| public readonly string $provider = '', | ||
| public readonly array $attributes = [], | ||
| public readonly ?\Throwable $exception = null | ||
| ) { | ||
| parent::__construct(); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Prism\Prism\Events; | ||
|
|
||
| class PrismRequestStarted extends TraceEvent | ||
| { | ||
| /** | ||
| * @param array<string, mixed> $attributes | ||
| */ | ||
| public function __construct( | ||
| public readonly string $provider, | ||
| public readonly array $attributes | ||
| ) { | ||
| parent::__construct(); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Prism\Prism\Events; | ||
|
|
||
| class ToolCallCompleted extends TraceEvent | ||
| { | ||
| /** | ||
| * @param array<string, mixed> $attributes | ||
| */ | ||
| public function __construct( | ||
| public readonly array $attributes = [], | ||
| public readonly ?\Throwable $exception = null | ||
| ) { | ||
| parent::__construct(); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Prism\Prism\Events; | ||
|
|
||
| class ToolCallStarted extends TraceEvent | ||
| { | ||
| /** | ||
| * @param array<string, mixed> $attributes | ||
| */ | ||
| public function __construct( | ||
| public readonly string $toolName, | ||
| public readonly array $attributes | ||
| ) { | ||
| parent::__construct(); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Prism\Prism\Events; | ||
|
|
||
| use Illuminate\Foundation\Events\Dispatchable; | ||
| use Illuminate\Queue\SerializesModels; | ||
| use Prism\Prism\Support\Trace; | ||
|
|
||
| /** | ||
| * @property-read array{traceId:string, parentTraceId:string|null, traceName:string, startTime:float, endTime:float|null}|null $trace | ||
| */ | ||
| class TraceEvent | ||
| { | ||
| use Dispatchable, SerializesModels; | ||
|
|
||
| /** @var array{traceId:string, parentTraceId:string|null, traceName:string, startTime:float, endTime:float|null}|null */ | ||
| public readonly ?array $trace; | ||
|
|
||
| public function __construct() | ||
| { | ||
| $this->trace = Trace::get(); | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont know if I like the configuration method approach for this. I think I'd rather like to just return a base client with the middleware defined and then let the providers can customize the client as needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I submitted a PR #427 just for the client trait using a
baseClientwhere we can add middlewares and the rest of configuration happens in provider client. Is that what you meant?I separated in another PR because I refactored exceptions that were scattered in all handlers and that added a lot of noise that I'd like to keep separate from this PR.