Remove the test cfg gate #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This feels like a hack, but if it simplifies stuff on your end I will give in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For one, the readme showcases code that adds
#[cfg(test)]above#[embedded_test::tests]so users (us :D ) already think it's necessary.The other reason for this PR is a bit more nuanced.
cargo build --test xy --artifact-dir place-the-test-heredoesn't work. This prevents us from using cargo-batch to build tests in one go (or, well, fewer than 50 gos). However, the cfg prevents us from turning the test binaries into "real" binaries, where everything just works.