Skip to content

MIDI CC 07 (Volume) on PCCH sets Master Volume #923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
probonopd wants to merge 3 commits into
base: main
Choose a base branch
from
+8 −0
Open

MIDI CC 07 (Volume) on PCCH sets Master Volume #923

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c99e824
MIDI CC 07 (Volume) on PCCH sets Master Volume\n\n- When MIDI CC 07 i…
probonopd May 19, 2025
5c81b62
Do not process further for TGs
probonopd May 20, 2025
d903016
The crash is gone?
probonopd May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/mididevice.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,10 +279,18 @@ void CMIDIDevice::MIDIMessageHandler (const u8 *pMessage, size_t nLength, unsign
{
m_pSynthesizer->BankSelectLSBPerformance (pMessage[2]);
}
else if (pMessage[1] == MIDI_CC_VOLUME && nLength == 3) // CC 07 on PCCH: Master Volume
{
float fMasterVolume = (float)pMessage[2] / 127.0f;
m_pSynthesizer->setMasterVolume(fMasterVolume);
LOGNOTE("MIDI CC07 (Volume) on PCCH: Set Master Volume to %d (%.3f)", pMessage[2], fMasterVolume);
return; // Do not process further for TGs
}
else
{
// Ignore any other CC messages at this time
LOGNOTE("Ignoring CC %d (%d) on Performance Select Channel %d\n", pMessage[1], pMessage[2], nPerfCh);
break; // Already handled PCCH message
}
}
}
Expand Down
Loading