Skip to content

utils.str: Handle \0 in perlReToReplacer #1536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

utils.str: Handle \0 in perlReToReplacer #1536

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/utils/str.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,8 @@ def perlReToReplacer(s):
regexp = regexp.replace('\x08', r'\b')
replace = replace.replace('\\'+sep, sep)
for i in range(10):
replace = replace.replace(chr(i), r'\%s' % i)
replace = replace.replace(chr(i), r'\g<%s>' % i)
replace = replace.replace(r'\0', r'\g<0>')
Copy link
Owner

@progval progval May 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line looks redundant

g = False
if 'g' in flags:
g = True
Expand Down
4 changes: 4 additions & 0 deletions test/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,10 @@ def testPerlReToReplacer(self):
self.assertEqual(f('foo'), 'foo/bar')
f = PRTR('s/^/foo/')
self.assertEqual(f('bar'), 'foobar')
f = PRTR('s/bar/foo\0/')
self.assertEqual(f('bar'), 'foobar')
f = PRTR(r's/bar/foo\0/')
self.assertEqual(f('bar'), 'foobar')

def testMultipleReplacer(self):
replacer = utils.str.MultipleReplacer({'foo': 'bar', 'a': 'b'})
Expand Down