-
Notifications
You must be signed in to change notification settings - Fork 16
Ehancement: Named AgentSet
+ flexible lookup & stricter separation of concerns
#172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
adamamer20
wants to merge
162
commits into
main
Choose a base branch
from
146-enhancement-consider-using-a-key-based-structure-for-agentsets-instead-of-list-in-agentsdf
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
162 commits
Select commit
Hold shift + click to select a range
e1cd30a
Add abstract name property and rename method to AgentSetDF for enhanc…
adamamer20 b385314
Refactor agent retrieval in ModelDF to use dictionary access for impr…
adamamer20 69b56c1
Enhance AgentSetPolars with unique naming and renaming capabilities
adamamer20 f04cfcf
Add abstract base class for agent sets accessors with comprehensive API
adamamer20 af0f270
Implement AgentSetsAccessor class for enhanced agent set management a…
adamamer20 4c60083
Add KeyBy literal for common option types in type definitions
adamamer20 637f560
Refactor AgentSetsAccessor to use direct access to agent sets for imp…
adamamer20 f823400
Fix type hint in constructor and improve default handling in get meth…
adamamer20 f190d86
Remove redundant test for agent sets by type in Test_AgentsDF
adamamer20 85effbc
Add rename method to AgentSetsAccessor for agent set renaming with co…
adamamer20 53cd1d2
Refactor name handling in AgentSetPolars to simplify uniqueness manag…
adamamer20 3cf2c06
Implement unique name generation and canonicalization for agent sets …
adamamer20 a6e92ab
Enhance type handling in AgentSetsAccessor to provide detailed error …
adamamer20 4aaaf47
Enhance error handling in AgentsDF by providing available agent set n…
adamamer20 d649301
Add mesa package to development dependencies in uv.lock
adamamer20 951d5b6
Refactor __getitem__ method in AgentSetsAccessor to return matching a…
adamamer20 c5c8430
Add comprehensive tests for AgentSetsAccessor methods to ensure corre…
adamamer20 624c7a4
Merge branch 'main' of https://github.com/projectmesa/mesa-frames int…
adamamer20 d0a592a
Rename AgentSetsAccessorBase to AbstractAgentSetsAccessor for consist…
adamamer20 cf16fb6
Refactor AgentSetsAccessor to extend AbstractAgentSetsAccessor for im…
adamamer20 95bb9af
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 823732b
Refactor error handling in __getitem__ to use a set for available age…
adamamer20 ebbbf6b
Enhance code readability and organization by adding whitespace for cl…
adamamer20 f1ac41d
Merge branch '146-enhancement-consider-using-a-key-based-structure-fo…
adamamer20 7f5844a
Enhance docstring clarity and type annotations in AbstractAgentSetsAc…
adamamer20 930cd77
Enhance docstring clarity and type annotations in AgentSetsAccessor; …
adamamer20 bf5786a
Refactor docstring in AgentsDF.rename to clarify purpose and improve …
adamamer20 66b7054
Enhance docstring clarity and type annotations in AbstractAgentSetsAc…
adamamer20 cf56a7d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 7c2afac
Enhance type annotations and overloads in AbstractAgentSetsAccessor; …
adamamer20 686dfa5
Refactor type annotations in AbstractAgentSetsAccessor; replace Agent…
adamamer20 92ff76e
Refactor AgentSetsAccessor methods; replace mapping method with dict …
adamamer20 af24eb2
Merge branch '146-enhancement-consider-using-a-key-based-structure-fo…
adamamer20 bba59cc
Add rename method to AbstractAgentSetsAccessor for agent set renaming…
adamamer20 c54f9d9
Refactor rename method in AgentSetsAccessor; streamline docstring and…
adamamer20 c83e9e5
Refactor rename method in AbstractAgentSetsAccessor; improve type ann…
adamamer20 0f640fb
Refactor _rename_set method in AgentsDF; enhance functionality for si…
adamamer20 cab89a2
Refactor AbstractAgentSetsAccessor and AgentSetsAccessor; remove 'obj…
adamamer20 a652892
Add tests for AgentsDF's contains and remove methods; handle empty it…
adamamer20 6ed2419
Enhance tests for AgentSetsAccessor; add validation for key retrieval…
adamamer20 f53b464
Refactor keys method in AbstractAgentSetsAccessor for consistency; im…
adamamer20 d866171
Update return type of keys method in AbstractAgentSetsAccessor to exc…
adamamer20 006c1ab
Enhance _make_unique_name method in AgentsDF with detailed docstring;…
adamamer20 f7ef412
Implement camel_case_to_snake_case function for converting camelCase …
adamamer20 c209c1b
Refactor AgentSetPolars to convert proposed name to snake_case if in …
adamamer20 e603996
Refactor camel_case_to_snake_case function for consistency in regex s…
adamamer20 d38351e
Refactor _camel_to_snake function for consistent regex string delimit…
adamamer20 8f9fa54
Enhance AgentContainer type hints to support string and collection of…
adamamer20 f80083c
Refactor AgentSetPolars to improve readability of name assignment; fo…
adamamer20 231e3bd
Refactor tests to use updated Model and AgentSet classes
adamamer20 8d7fe14
Refactor agent set imports and introduce AgentSetRegistry
adamamer20 a814dd8
Refactor import statements for better readability in space.py and age…
adamamer20 5dbe6f5
Fix formatting in AGENTS.md for MESA_FRAMES_RUNTIME_TYPECHECKING vari…
adamamer20 79e94e5
Update type hints in AbstractAgentSetRegistry to reference abstract a…
adamamer20 09cb336
Introduce AbstractAgentSet class and refactor imports for consistency
adamamer20 ab80df0
Update type hints in AbstractAgentSetRegistry to reference concrete A…
adamamer20 7878392
Refactor import statements in agentset.py for improved readability
adamamer20 47a5413
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] dfa2287
Update docstring in AbstractAgentSet and improve type hints in Abstra…
adamamer20 ad53071
Merge branch '171-enhancement-rename-agentsetdf-to-abstractagentsetdf…
adamamer20 c672924
Remove AbstractAgentSetsAccessor class and its associated methods fro…
adamamer20 5f2f0b3
Remove TestAgentSetsAccessor class and its associated tests from test…
adamamer20 4dff1d8
Rename test class from Test_ModelDF to Test_Model for consistency
adamamer20 927014c
Add abstract agent set classes and concrete agent set registry implem…
adamamer20 1396bc0
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 324a6c7
Merge branch '171-enhancement-rename-agentsetdf-to-abstractagentsetdf…
adamamer20 fccf344
Refactor GridPolars to Grid and update related references across the …
adamamer20 886c5f7
Merge branch '171-enhancement-rename-agentsetdf-to-abstractagentsetdf…
adamamer20 c8d77e2
Remove concrete implementation of AgentSetsAccessor for codebase cleanup
adamamer20 eaec185
Remove camel_case_to_snake_case function for codebase cleanup
adamamer20 6b1f3ad
Rename SpaceDF to Space and update related references for consistency
adamamer20 f46fbb9
Rename MoneyAgentDFConcise to MoneyAgentConcise and MoneyAgentDFNativ…
adamamer20 3cdd5c1
Update rename method documentation to reflect delegation to AgentSetR…
adamamer20 5f217b0
Remove unused properties from AgentSetRegistry for codebase cleanup
adamamer20 ca54b40
Update space type annotations to reflect Space object instead of Mult…
adamamer20 cc1f133
Fix get_unique_ids function to correctly cast unique_id series from m…
adamamer20 9cb79c2
Refactor space property type annotation to use Space instead of Space…
adamamer20 89454e2
Update copyright year in conf.py to use current year dynamically
adamamer20 36f132a
Rename MoneyAgentDF and MoneyModelDF classes to MoneyAgents and Money…
adamamer20 0771ef3
Add tests for CustomModel and its step functionality
adamamer20 a234bc8
Update space property type hint to use Space instead of SpaceDF for c…
adamamer20 95e2196
Simplify name assignment in AgentSet constructor for improved readabi…
adamamer20 028c91f
Format list comprehensions for improved readability in AgentSetRegist…
adamamer20 e4737d9
Rename parameter in ExampleModel constructor from 'agents' to 'sets' …
adamamer20 ec1a357
Reorder DataCollector import to avoid circular import error
adamamer20 26312a8
Merge branch '171-enhancement-rename-agentsetdf-to-abstractagentsetdf…
adamamer20 a3e2c56
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 040e00c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 9afda44
Remove unused import of camel_case_to_snake_case in agentset.py
adamamer20 d06139a
Merge branch '146-enhancement-consider-using-a-key-based-structure-fo…
adamamer20 5750a4f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 9a0ecc8
Merge branch 'main' into 171-enhancement-rename-agentsetdf-to-abstrac…
adamamer20 ae1390b
Add conftest.py to enable beartype runtime checking for tests
adamamer20 fd6f13b
Fix import order by adding a newline for clarity in __init__.py
adamamer20 ed8dc61
Enhance type hinting for agent parameters in Space and AbstractDiscre…
adamamer20 d9dc746
Refactor agent type checks to use AbstractAgentSetRegistry for improv…
adamamer20 b72e34b
Refactor AgentSet constructor and name property for improved clarity …
adamamer20 84f186f
precommit
Ben-geo d50b00f
Replace MoneyAgentDF with MoneyAgents in MoneyModel constructor for c…
adamamer20 98f4859
Rename MoneyAgentDF to MoneyAgents for consistency in agent set imple…
adamamer20 d3402ee
Update tutorial to reflect renaming of agent classes from MoneyAgentP…
adamamer20 2d4854f
Refactor MoneyModel and MoneyAgents classes for consistency and clari…
adamamer20 dcee916
Update DataCollector tutorial with execution results and fix agent we…
adamamer20 0828832
Refactor agent and model classes for consistency: rename MoneyModel t…
adamamer20 2cd4e00
Fix agent type reference in SugarscapePolars model: update from AntPo…
adamamer20 73fa761
Fix model_reporters lambda function in ExampleModel to correctly sum …
adamamer20 4e02ffc
Refactor agent and model classes for consistency: update references f…
adamamer20 3637a35
Fix missing newline at end of file in ExampleModel documentation
adamamer20 2826c5c
Remove unused import of Model in agentset.py
adamamer20 deeea1b
Merge branch '146-enhancement-consider-using-a-key-based-structure-fo…
adamamer20 2579e8b
Merge branch '171-enhancement-rename-agentsetdf-to-abstractagentsetdf…
adamamer20 475c4cb
Fix class name in documentation: update Space to AbstractSpace for cl…
adamamer20 ff15a0b
Merge branch '171-enhancement-rename-agentsetdf-to-abstractagentsetdf…
adamamer20 4ef6dfc
Refactor AbstractAgentSet class: remove inheritance from AbstractAgen…
adamamer20 50548de
Add method overloads for do and implement remove method in AgentSet c…
adamamer20 e08c928
Refactor AbstractAgentSet class: add remove method and improve agent …
adamamer20 809570d
Refactor AbstractAgentSetRegistry: update discard, add, and contains …
adamamer20 9ced330
Refactor type aliases in types_.py: reorganize imports, enhance Agent…
adamamer20 5b79c35
Refactor import statement in agentsetregistry.py: rename AbstractAgen…
adamamer20 6baec28
Refactor AgentSetRegistry: streamline imports, rename parameters for …
adamamer20 7f78887
Refactor AbstractAgentSetRegistry: add abstract methods keys, items, …
adamamer20 37d8922
Refactor AgentSetRegistry: add keys, items, and values methods for en…
adamamer20 33aa536
Refactor contains method in AgentSetRegistry: optimize type checks an…
adamamer20 e641f12
Refactor AgentSetRegistry: streamline method for resolving agent sets…
adamamer20 f847a57
Refactor AgentSetRegistry: simplify key retrieval logic and enhance e…
adamamer20 7588966
Refactor AgentSetRegistry: implement _resolve_selector method for imp…
adamamer20 6b7be9d
Refactor AgentSetRegistry: optimize agent removal logic and normalize…
adamamer20 e45efbe
Refactor AgentSetRegistry: add replace method for bulk updating of ag…
adamamer20 267e64b
Refactor AgentSetRegistry: simplify index key generation logic using …
adamamer20 963f949
Refactor AbstractAgentSetRegistry: update parameter names and types f…
adamamer20 073b6db
Refactor AgentSet: update model parameter type for improved clarity
adamamer20 a8b615e
Refactor get_unique_ids: update implementation for clarity and correc…
adamamer20 26eaefc
Refactor AgentSet: enhance agent removal logic with validation for un…
adamamer20 8afca27
Refactor AgentSetRegistry: improve agent set name assignment logic fo…
adamamer20 a43da1a
Refactor Model: update step method to use public registry API for inv…
adamamer20 ccbd8a0
Refactor Space: improve agent ID validation and handling using public…
adamamer20 4b832e1
Add comprehensive tests for AgentSetRegistry functionality
adamamer20 393a5db
Enhance agent reporter functionality: support string collections and …
adamamer20 500bc23
Refactor agent reporter lambda functions to use sets parameter for we…
adamamer20 6f62e99
Refactor test assertions in TestAgentSetRegistry for improved readabi…
adamamer20 95cf996
Refactor DataCollector model reporters for improved efficiency and re…
adamamer20 352f2af
Fix execution counts in DataCollector tutorial notebook for consistency
adamamer20 4a2018e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 065bea8
Implement rename functionality for AgentSet and AgentSetRegistry with…
adamamer20 03575eb
Refactor test assertion in TestAgentSetRegistry to use set literal fo…
adamamer20 5e6dd9a
Enhance parameter documentation for agent handling and rename functio…
adamamer20 1c3a63b
Merge branch '146-enhancement-consider-using-a-key-based-structure-fo…
adamamer20 647f5b6
Update documentation to clarify usage of AgentSetRegistry and improve…
adamamer20 cb139b1
fix ss_polars
adamamer20 5c68bd8
formatting
adamamer20 2c43b3f
Merge branch 'main' of https://github.com/projectmesa/mesa-frames int…
adamamer20 7c53eb8
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] cdcdfc8
fix: remove conflict markers by preferring OURS from 2c43b3f5e9283be5…
adamamer20 d7d5ca8
remove old test_agents.py
adamamer20 5f89f07
feat: add abstract rename method to AbstractAgentSet for consistent n…
adamamer20 acf9c50
feat: add abstract set method to AbstractAgentSet for updating agent …
adamamer20 2935894
Remove obsolete OLD_concrete_accessors.py and OLD_concrete_agents.py …
adamamer20 0e1044c
refactor: streamline key management methods in AgentSetRegistry and e…
adamamer20 4187380
feat: enhance key handling in AbstractAgentSetRegistry for string keys
adamamer20 4ef1a25
refactor: remove unused _skip_copy attribute from CopyMixin
adamamer20 073bb90
refactor: improve key handling and update logic in AgentSetRegistry
adamamer20 dccc834
fix: specify exception type in DataCollector to improve error handling
adamamer20 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.