Set ping traffic class to zero by default #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeremiah Millay <[email protected]>
floatingstatic
force-pushed
the
tclass-default
branch
from
a95ccff to
7c66d7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under #120 a change was introduced that sets the default traffic class to a non-zero value by default. This does not align with default behavior of the standard ping utility. I do not feel it is appropriate to set a non-zero default value here and in my own network running many active probes I observed a number of paths that appeared to be "clean" based on pro-bing probes running that were actually lossy with standard ping (DSCP bit set to 0 in ip headers). This caused a long troubleshooting effort to come to the realization that pro-bing sets non-zero DSCP in ping packets it produces and some upstream transit providers were not scrubbing DSCP and thus prioritizing these packets as non-best-effort in their QoS policies which is why our measurements were appearing to be clean when in fact they were not.
Please consider setting the traffic class setting to zero by default.