forked from bazelruby/rules_ruby
-
Notifications
You must be signed in to change notification settings - Fork 4
Use RUBY_BASE_NAME, since that is what the libdir uses
#38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tempoz
added a commit
to tempoz/protobuf
that referenced
this pull request
Sep 11, 2024
JasonLunn
requested changes
Sep 26, 2024
tempoz
commented
Oct 3, 2024
JasonLunn
approved these changes
Oct 11, 2024
copybara-service bot
pushed a commit
to protocolbuffers/protobuf
that referenced
this pull request
Oct 11, 2024
copybara-service bot
pushed a commit
to protocolbuffers/protobuf
that referenced
this pull request
Oct 11, 2024
copybara-service bot
pushed a commit
to protocolbuffers/protobuf
that referenced
this pull request
Oct 11, 2024
copybara-service bot
pushed a commit
to protocolbuffers/protobuf
that referenced
this pull request
Oct 11, 2024
See protocolbuffers/rules_ruby#38. This fixes the ruby portion of the protocolbuffers build for me. Closes #18233 COPYBARA_INTEGRATE_REVIEW=#18233 from tempoz:tempoz-ruby-fix 2aee6e1 PiperOrigin-RevId: 684969223
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documented here: https://idiosyncratic-ruby.com/42-ruby-config.html
Without this patch, I get:
and if I only change enough to fix that specific error, I get:
when trying to build https://github.com/protocolbuffers/protobuf