Chat toolbar

[stokito]

I noticed that the group chat has the burger menu with Actions.

If disable the toolbar above message editor with options.ui.contactlist.toolbars.m1.visible it also shows the Smiles picker which is IMHO better to remove from there - it's too far from the editor and honestly not really needed. Please tell me if you will be fine to remove it.

But the personal chat doesn't have the Actions menu. It turned out that it's hidden if enabled the toolbar.

It should be always shown, similar menu is used in other clients so a user may expect it there. I removed the code to hide it and also made it look similar to the menu in the group chat.

Similarly it also shows the Smiles picker that is probably would be better to remove. The chars counter is probably also not used.

[Ri0n]

honestly i would only leave the burger there and the emoticons selector moved somewhere close to the mic icon like in popular messengers. the emots selector definitely shouldn't be hidden.
And this jid thing on the toolbar is ugly =) But there is no other way to quickly understand the account owning the chat.

and wrt to the characters counter @Neustradamus adores it.. I don't like it though.

[stokito]

the emots selector definitely shouldn't be hidden

The toolbar has the emoticons icon and it's enabled by default.
Other clients have an emoticons in context popup menu and as a separate buttons close to the edit field on left of right. We can do this too, but generally speaking this will make the toolbar useless because it will contain almost same buttons. I'm pretty sure that no one uses the Smiles button on the top so let's remove it.

[Ri0n]

Well I definitely don't use it there coz I have the middle toolbar enabled.
But the thing is, before removing a frequently used feature let's make an alternative solution.

[Neustradamus]

@stokito: Good catch for the problem if Chat or Groupchat toolbar is disabled.

Several options exist, enable/disable/select are in Options -> Toolbars:

• Chat: https://i.ibb.co/s9yXgR9F/psi-toolbar-chat.png
• Groupchat: https://i.ibb.co/FG7yQYK/psi-toolbar-groupchat.png
• ...

About "XMPP Account" info which is in Chat and Groupchat (MUC Room) tabs because this XMPP client is multi-accounts and it must seen directly to do not mix.
An option can be added to enable or disable but it must never removed.
It is linked to "AccountLabel" and "lb_ident".

Note: At the same time, there are several OMEMO problems with multi-accounts which must be solved since always.

About "Character counter" (Message length) info which is in Chat tab, there is already an option to enable or disable: Options -> Messages -> Common -> Show character counter (at the same time, it is missing in Groupchat, must be added).
This option can be disabled by default but it must never removed.
It is linked to "QLabel" and "lb_count".

[Neustradamus]

Harmonization of "Actions" is needed, the icon must be same for Chat and Groupchat...

[stokito]

The PR just the "harmonization of actions" so it can be merged. The UI discussion is something that should be discussed separately and ideally it should be similar to other clients, so it's better to discuss on the Modern XMPP.
I just proposed to remove the certainly unused Emoticons button but this becomes a bigger issue of reducing the toolbar to message's side buttons. We may back to this later, just for now let's see the screenshot of the Gajim:

[Neustradamus]

@stokito: First, it is not because other XMPP Clients have not same UI that it is needed to do same.

Harmonization of Chat and Groupchat "Actions" icon (menu or burger name) is needed but not the removal of the Chat or Groupchat toolbar etc.

One advantage of Psi/Psi+ is that it can be customized (show/hide options), not removal features.
If a show/hide option is missing, it can be added.

Account label (lb_ident), Message length (lb_count) must not be removed...

[Neustradamus]

@stokito: About UI and OMEMO, OTR, OpenPGP icons, there are two tickets:

• Common button for choosing of Plain Text mode or OpenPGP/OTR/OMEMO Encryption | Chat toolbar | Groupchat toolbar #363
• Interaction between encryption plugins: OMEMO, OTR and OpenPGP should not be used simultaneously #437

[Neustradamus]

@stokito: Please look screenshots of Chat and Groupchat toolbars:

• Chat: https://i.ibb.co/s9yXgR9F/psi-toolbar-chat.png
• Groupchat: https://i.ibb.co/FG7yQYK/psi-toolbar-groupchat.png

OMEMO/OTR/OpenPGP icons are here.

[Ri0n]

but generally speaking this will make the toolbar useless because it will contain almost same buttons

not quite, emoticons button is just something considered to be frequently used. Other stuff with disabled toolbars may go to the burger menu, but not the emots button.