-
-
Notifications
You must be signed in to change notification settings - Fork 128
Profile Info: autocomplete for country #928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
yep rfc doesn't force anything real there |
I think you should use QLocale to list countries |
d529207
to
7b041c2
Compare
@Ri0n I figured out how to use the QLocale.Country so used it and removed the countries.tsv. |
что за CAP ? |
Префиксует в заголовок "Psi: " или "Psi+: ": QString CAP(const QString &str) { return QString("%1: %2").arg(ApplicationInfo::name(), str); } Я сделал как в других окнах. Лично я бы убрал его и просто везде прямо в строки добавил "Psi: " чтобы не делать конкатенацию и упростить код. Но тогда в + будет "Psi: " что, как по мне, не проблема вообще. Может удалить этот макрос? |
хе. совершенно не помню о существовании такой штуки =) |
то да, всё таки лишний код, да и место подъедает. Иконки должно быть достаточно. Можно убрать совсем префиксы. |
У меня такая же реакция была. Оказалось в common эта функция. И да возможно в некоторых случаях нужен |
Could you merge the PR? |
On user profile details there is Location tab with Country field.
I wanted to make it as a QComboBox to simplify typing but this component can't be used directly. So I added manual auto-completion.
It's not clear what should be in the Country field of vCard: country code or name. It looks like a user is free to write anything there, but as far I remember Miranda uses an English country name there. I think for now that should be ok. At least it didn't become worse.
There is some minor refactoring in the PR:
info.ui: arrange controls by rows - nothing changed, just moved together items by row=0 col=0.
Extracted a function to read a file content or lines in a single call.