make a more informative error dialog in mucjoindlg #1
#939
Conversation
src/mucjoindlg.cpp
Outdated
| QMessageBox::information( | ||
| this, | ||
| tr("Error"), | ||
| tr("You are in or joining this room already!\n\n- Account: %1\n- Room: %2\n" |
There was a problem hiding this comment.
hm maybe to ease translations it would be better to
QString("%1\n\n- %2: %3\n- %4: %5").arg(
tr("You are in or joining this room already!"),
tr("Account"),
account_->jid().bare(),
tr("Room"),
j.bare()
);
And please don't use formatting with extra spaces in translatable strings. It will look weird in other translations. You can try to use html instead (read about rich text in QMessageBox docs)
- like @rion pointed out pass variable text in the `tr` function, will broke the translation of the project. - also, hardcoded spaces in order to make a good looking message, is rather impossible to stay after a translation, so this is not the way either. - play some with html, but when doing that long texts will make the messages to wrap in the first dash `-` ... - so for now, also to keep a common look to these kind of dialogs, i think @rion's simple example is how it should be.
|
|
** another |
|
the modality is easy to fix. just don't use static helpers to show the dialog. create it explicitly via new |
2 participants
biboumiirc gateway, that keep connections open with upstream irc networks,found my self in the case of seeing a dialog like:
You are in or joining this room already, without to be able to figure out what is thatroom, or what is theaccounti'm trying to connect with.