Fix file state loss on page refresh (#5450)#5480
Open
anandjha249 wants to merge 1 commit intopterodactyl:1.0-developfrom
Open
Fix file state loss on page refresh (#5450)#5480anandjha249 wants to merge 1 commit intopterodactyl:1.0-developfrom
anandjha249 wants to merge 1 commit intopterodactyl:1.0-developfrom
Conversation
3 tasks
Author
wdym? |
Contributor
It was because of my message. I didn't remember that it could be deleted |
Author
any idea on how long would it take for the checks to be started all are currently in pending state |
Contributor
"This workflow is awaiting approval from a maintainer in #5480" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
File directory and editor content are lost when refreshing the page while creating a new file.
Video: https://imgur.com/PimtXLg (From the original issue thread)
Videos(Fixed)
Video1 : https://imgur.com/a/cWXsI1K
Video2 : https://imgur.com/a/IW9aaZV
Closes #5450
Problem
/Cause
When
action === 'new', the directory state was never initialized from the URL hash, causing it to default to/.Solution
localStorageand restore it after refreshScope
action === 'new'Testing
Important