refactor: remove dedicated migrations container and run migrations in instrumentation.ts instead #1383
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue(s) Resolved
Removes the need for self-hosted users (and us) to keep around and download the gigantic
platform-migrationscontainer by instead running migrations incoreinstead usinginstrumentation.ts.High-level Explanation of PR
First, we upgrade to
prismav6. This is not technically necessary, but a good idea to keep up to date i think.Secondly, add a new
instrumentation.migrate.tsfile, which just runs the migrations usingprisma migrate deploy. It will auto use the correct env vars that next also has access to.Finally, remove the
initcontainer in our terraform config, and remove themigrationscontainer in the self hosting config.We still build this container because we use it as the
bastion. We should probably not upload it toghcranymore tho, as it serves no purpose there.Test Plan
Make sure tests pass, check if i forgot to replace a migration somewhere else!
Screenshots (if applicable)
Notes