Conversation
puiterwijk
reviewed
Jan 24, 2022
openidc_client/requestsauth.py
Outdated
|
|
||
|
|
||
| class OpenIDCClientAuther(requests.auth.AuthBase): | ||
| class OpenIDCClientAuther(httpx.Auth): |
Owner
There was a problem hiding this comment.
I would prefer it if we keep this one in place, and create a second one for httpx. This way we don't break for people that are using requests still.
Owner
|
@kushaldas yeah, we should probably use the |
Also updates the tests and applies black as formatting on the codebase.
Author
|
@puiterwijk updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also updates the tests and applies black as formatting on the
codebase.
Maybe I should remove the hook and use update the
auth_flowlike the example in https://www.python-httpx.org/advanced/#customizing-authentication@puiterwijk please let me know what do you think. Maybe it will not work because I kept the original connection reuse part. I don't have a system to verify this.