Open
Conversation
trickypr
requested changes
Jan 8, 2023
|
|
||
| const sidebartabs = browser.menus.create({ | ||
| title: 'Add to Sidebar', | ||
| contexts: ['page'], |
Member
There was a problem hiding this comment.
So, if I right click in a blank part of the page, I can add the page to the sidebar, but if I right click on the tab I cannot. If I right click on selected text I cannot.
Also, shouldn't I be able to right click on a link to add it to the sidebar? That was what I thought this was itnened to fix at first.
Please review the valid context menu types: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/menus/ContextType
Member
Author
There was a problem hiding this comment.
Hmm the link adding to sidebar sounds like a cool addition. I thought it was the page itself but will change to add both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes pulse-browser/browser#168