(PE-39118) Adding code manager check to add_replica #501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
requested changes
Sep 16, 2024
CoMfUcIoS
approved these changes
Sep 18, 2024
bastelfreak
approved these changes
Sep 18, 2024
CoMfUcIoS
pushed a commit
to CoMfUcIoS/puppetlabs-peadm
that referenced
this pull request
Sep 19, 2024
* (PE-39118) Adding code manager check to add_replica * Fixing lint, and changing null return to false * Adding VERIFY_PEER
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When user tries to add replica without code manager setup they were getting an error without any descriptive message.
This is adding a check to add_replica to alert user to enable code manager before proceeding.
Checklist
Changes include test coverage?
Have you updated the documentation?