(CAT-2413) Defaults puppetcore agent version to newest if none given #798
Conversation
david22swan
changed the title
david22swan
force-pushed
the
CAT-2413
branch
2 times, most recently
from
ccda2cb to
3e0f43f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
david22swan
force-pushed
the
CAT-2413
branch
2 times, most recently
from
c298169 to
568863c
Compare
When puppetcore is selected without a specified version, this change defaults to the latest 8.x version available. This prevents errors caused by the download site requiring a version parameter. Relates to CAT-2413
| map(select(startswith("8."))) | | ||
| max_by(split(".") | map(tonumber))') | ||
| fi | ||
|
|
There was a problem hiding this comment.
Hmm, there's no guarantee jq is installed on the system where we're trying to install the agent... Since this latest business is a hack for platforms without package managers, I'm thinking we should just fail if version is unset on Windows and macOS. That way the caller will know it needs to provide an explicit version. Then in CI, it should be easy to run curl | jq on an ubuntu worker and pass the version into the test.
There was a problem hiding this comment.
It is less of a priority on our end now that the nightly images are up for us to grab.
Was mainly continuing with this for the teams that don't want to use nightlies, but if they haven't commented about it yet then they either have their own solution or aren't running on Windows/Mac
There was a problem hiding this comment.
Have opened a second PR which adds error messages: #801
| download_url="${mac_source}?type=native&version=${version}&os_name=osx&os_version=${platform_version}&os_arch=${arch}&dev=true" | ||
| else | ||
| download_url="${mac_source}?version=${version}&os_name=osx&os_version=${platform_version}&os_arch=${arch}" | ||
| download_url="${mac_source}?type=native&version=${version}&os_name=osx&os_version=${platform_version}&os_arch=${arch}" |
There was a problem hiding this comment.
when/why did type become required?
There was a problem hiding this comment.
A while back, ever since the site started hosting the pdk I think..
There was a problem hiding this comment.
With multiple products up, an identifier was needed
When puppetcore is selected without a specified version, this change defaults to the latest 8.x version available.
This prevents errors caused by the download site requiring a version parameter.
Relates to CAT-2413