✨ Added Motor Group Append/Erase Functions#707
Open
Gracelu128 wants to merge 4 commits intodevelop-pros-4from
Open
✨ Added Motor Group Append/Erase Functions#707Gracelu128 wants to merge 4 commits intodevelop-pros-4from
Gracelu128 wants to merge 4 commits intodevelop-pros-4from
Conversation
WillXuCodes
requested changes
Dec 26, 2024
Comment on lines
+2361
to
+2368
| /** | ||
| * Appends all the motors on the port to this motor group | ||
| * | ||
| * \param port The port to append to the motor group | ||
| * | ||
| */ | ||
| void append(std::int8_t port); | ||
|
|
Member
There was a problem hiding this comment.
Needs some doc updates on rejection conditions (such as if the same absolute value port is found in the motor group)
|
|
||
|
|
||
| } // namespace v5 | ||
| } // namespace pros No newline at end of file |
Member
There was a problem hiding this comment.
Add newline before merge (not part of changes in this PR but missing in general)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Added append function that takes in port number and erase function that takes in reference to motor group.
Motivation:
The append function previously required a reference to the motor group, and the erase function required a port number. This update allows the append function to accept a port number, and the erase function to use a reference to the motor group.
Test Plan: