Skip to content

Conversation

@kushaldas
Copy link
Contributor

@kushaldas kushaldas commented Dec 21, 2025

Now we have typing information added to the project and also enabled checking in CI.

Need help: someone please help with those 3 lines of missing coverage. I will try to add something with a static key for testing those lines for codecov.

@kushaldas kushaldas marked this pull request as ready for review December 21, 2025 06:33
@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.54%. Comparing base (1ff2114) to head (f599d96).
⚠️ Report is 13 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #223      +/-   ##
==========================================
+ Coverage   90.17%   91.54%   +1.37%     
==========================================
  Files          15       15              
  Lines        2625     2674      +49     
  Branches       29       27       -2     
==========================================
+ Hits         2367     2448      +81     
+ Misses        255      224      -31     
+ Partials        3        2       -1     
Flag Coverage Δ
unittests 91.54% <100.00%> (+1.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@MatthiasValvekens MatthiasValvekens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution! Approved in principle, modulo a couple nits.

Now we have typing information added to the project and also
enabled checking in CI.
@MatthiasValvekens MatthiasValvekens merged commit ecf10f7 into pyauth:master Dec 21, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants