Fix Cargo.lock mismatch in generated sdist#235
Merged
davidhewitt merged 1 commit intopydantic:mainfrom Mar 18, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Alex-Izquierdo
commented
Mar 11, 2026
| edition = {workspace = true} | ||
| authors = {workspace = true} | ||
| # Internal-only crate (`publish = false`): keep version decoupled from release crates. | ||
| version = "0.0.0" |
Contributor
Author
There was a problem hiding this comment.
If versioning this crate is essential (I understand it is not) I can create some makefile target to keep it updated and/or some inclusion in pre-commit/ci. For now I prefer to Keep It Simple
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The root workspace currently includes
crates/fuzz, which is an internal, non-published fuzzing crate.When building the source distribution, that crate is not included, but the packaged
Cargo.lockis still produced from a workspace that includes it. This mismatch causescargo vendor --lockedto fail and breaks offline/reproducible downstream builds.This PR removes
crates/fuzzfrom the published workspace, makescrates/fuzzexplicitly independent from the root workspace, and adds a CI regression check to ensure locked vendoring works against the unpacked sdist.Fixes #196.