Skip to content

Conversation

@prady0t
Copy link
Collaborator

@prady0t prady0t commented Aug 2, 2025

What type of PR is this? (check all applicable)

  • 💾 Refactor
  • 🪄 Feature
  • 🐞 Bug Fix
  • 🔧 Optimization
  • 📚 Documentation
  • 🧪 Test
  • 🛠️ Other

Related issues

Checklist

  • Code follows style guide
  • Tests added
  • Documented the changes

Please explain your changes below.

prady0t added 4 commits August 2, 2025 13:49
Signed-off-by: Pradyot Ranjan <[email protected]>
Signed-off-by: Pradyot Ranjan <[email protected]>
Signed-off-by: Pradyot Ranjan <[email protected]>
Signed-off-by: Pradyot Ranjan <[email protected]>
@prady0t
Copy link
Collaborator Author

prady0t commented Aug 2, 2025

@hameerabbasi, could you review this whenever free? I've added the "Notebooks" section in nav (and it's visible, but not on the home page with an icon just like other sections). Currently, there are also some failures in the Jupyter notebook itself.

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 2, 2025

CodSpeed Performance Report

Merging #894 will degrade performances by 15.31%

Comparing prady0t:notebooks (842f4d5) with main (5cf299c)

Summary

❌ 1 regression
✅ 339 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_index_slice[side=100-rank=2-format='gcxs'] 2 ms 2.4 ms -15.31%

Copy link
Collaborator

@hameerabbasi hameerabbasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like matplotlib needs to be added to the docs dependencies.

@hameerabbasi
Copy link
Collaborator

Also please rebase on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Include notebooks in documentation

2 participants