Skip to content

Import h5netcdf.core to use EnumType #10779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Import h5netcdf.core to use EnumType #10779

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b481ae8
Import EnumType from h5netcdf.core directly
maxrjones Sep 23, 2025
e9f53b8
Support older h5netcdf
maxrjones Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions xarray/backends/h5netcdf_.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,8 +237,8 @@ def ds(self):
return self._acquire()

def open_store_variable(self, name, var):
import h5netcdf
import h5py
from h5netcdf.core import EnumType

dimensions = var.dimensions
data = indexing.LazilyIndexedArray(H5NetCDFArrayWrapper(name, self))
Expand Down Expand Up @@ -276,7 +276,7 @@ def open_store_variable(self, name, var):
# just check if datatype is available and create dtype
# this check can be removed if h5netcdf >= 1.4.0 for any environment
elif (datatype := getattr(var, "datatype", None)) and isinstance(
datatype, h5netcdf.core.EnumType
datatype, EnumType
):
encoding["dtype"] = np.dtype(
data.dtype,
Expand Down
Loading