Skip to content

Conversation

mrbean-bremen
Copy link
Member

  • evaluate conditions in sequences lazily to make sure to check the correct dataset
  • this also allows recursively defined sequence attributes

Fixes #206. Structured Reports should now be correctly handled.

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2025

Codecov Report

❌ Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.35%. Comparing base (e8644e2) to head (49629de).
⚠️ Report is 135 commits behind head on main.

Files with missing lines Patch % Lines
dicom_validator/validator/iod_validator.py 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #213      +/-   ##
==========================================
- Coverage   89.82%   89.35%   -0.48%     
==========================================
  Files          15       19       +4     
  Lines        1632     1917     +285     
==========================================
+ Hits         1466     1713     +247     
- Misses        166      204      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- evaluate conditions in sequences lazily
  to make sure to check the correct dataset
- this also allows recursively defined sequence attributes
@mrbean-bremen mrbean-bremen merged commit 9e8a1e7 into pydicom:main Oct 7, 2025
16 checks passed
@mrbean-bremen mrbean-bremen deleted the recursive-refs branch October 7, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The "Comprehensive SR Document" is read without errors by dsrdump, but the validator still reports some issues.

2 participants